Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons separators in RWD mobile should not be full height #7704

Closed
oleq opened this issue Jul 24, 2020 · 0 comments · Fixed by #8232
Closed

Buttons separators in RWD mobile should not be full height #7704

oleq opened this issue Jul 24, 2020 · 0 comments · Fixed by #8232
Assignees
@pkwasnik
Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 37 (v23...

Comments

@oleq
Copy link
Member

oleq commented Jul 24, 2020

📝 Provide a description of the improvement

We changed the way separators look in the toolbars to better integrate with balloons but we forgot about RWD forms (e.g. link):

These styles should also be updated if possible.

cc @panr 

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. domain:ui/ux This issue reports a problem related to UI or UX. squad:red domain:mobile This issues reports a problem related to a mobile environment. labels Jul 24, 2020
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:red labels Jul 28, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Aug 3, 2020
@Reinmar Reinmar added the intro Good first ticket. label Sep 4, 2020
@jodator jodator modified the milestones: nice-to-have, iteration 37 Oct 8, 2020
@pkwasnik pkwasnik mentioned this issue Oct 9, 2020
Merged
jodator added a commit that referenced this issue Oct 20, 2020
@jodator
Merge pull request #8232 from ckeditor/i/7704
6aecaf8 
Fix (link): Improve link balloon buttons separators look on mobiles. Closes #7704.
@oleq oleq mentioned this issue Oct 20, 2020
Closed
@pkwasnik pkwasnik mentioned this issue Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 37 (v23.1.0)
Development

Successfully merging a pull request may close this issue.

Buttons separators in RWD mobile should not be full height ckeditor/ckeditor5
4 participants
@Reinmar @jodator @oleq @pkwasnik