Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding automatic dependency management #907

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Adding automatic dependency management #907

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
445f5bb
Adding automatic dependency management
DarkWanderer Dec 14, 2022
40cf560
Update per review notes
DarkWanderer Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: 2
updates:
- package-ecosystem: cargo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot the quotes around cargo. Same in the second entry below.

Suggested change
- package-ecosystem: cargo
- package-ecosystem: "cargo"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't forget anything, it works this way. YML spec allows for unquoted string values.

The fact that I listened to suggestions above does not mean that I will spend my time on nitpicks however

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only noticed since you did use quotes for github-actions. My apologies if I somehow offended you. Personally I'm always happy if someone points out such inconsistencies in my code.

directory: "/"
schedule:
interval: "daily"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"