-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding automatic dependency management #907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Note that we will not be able to upgrade to time 0.1 in the chrono 0.4.x series due to compatibility constraints but we've already removed it from the main branch.
From what I've seen elsewhere dependabot can often provide a lot of PRs for semver patch updates. I wonder whether we would be better off adding |
Looks like we already have dependabot security updates enabled for this repo, and from what I can see over at SO this is the only way to get dependabot to do security updates only. |
I usually enable a Dependabot config like this in most of the projects I maintain. It will send PRs for semver-incompatible releases in our dependencies, which I think is useful, but it also has pretty good support for ignoring new releases (like time 0.3.x). It will not send PRs for semver-compatible releases, so I think this would be good addition. I also usually add cargo-deny to my CI configurations, which will help specifically with the security aspects. I'll submit a PR for that. |
From what I've seen Dependabot only sends PRs for semver patch updates if I'd only change the interval to |
Oh, and it would be good to add an entry covering |
Don't worry about the failed lint check. That's a new clippy warning that shows up since Rust 1.66 was released a few hours ago. A fix is included in this PR. |
@@ -0,0 +1,14 @@ | |||
version: 2 | |||
updates: | |||
- package-ecosystem: cargo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot the quotes around cargo
. Same in the second entry below.
- package-ecosystem: cargo | |
- package-ecosystem: "cargo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I didn't forget anything, it works this way. YML spec allows for unquoted string values.
The fact that I listened to suggestions above does not mean that I will spend my time on nitpicks however
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only noticed since you did use quotes for github-actions
. My apologies if I somehow offended you. Personally I'm always happy if someone points out such inconsistencies in my code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @DarkWanderer for the PR and @djc for the clarification
There is an open security advisory for
time
library whichchrono
is dependent upon: https://github.com/DarkWanderer/DynamicOperations/security/dependabot/4Having
dependabot
integration will help to react to such issues in timely manner