Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybookUrl by removing iframe.html suffix #518

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Fix storybookUrl by removing iframe.html suffix #518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dc771f
fix #409 by stripping ifram.html off (and everything after it)
ndelangen Feb 11, 2022
7d20e58
Merge branch 'main' into norbert/sb-104-github-action-storybookurl-ou…
ghengeveld Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action-src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ async function runChromatic(options): Promise<Output> {
url: ctx.build?.webUrl,
code: ctx.exitCode,
buildUrl: ctx.build?.webUrl,
storybookUrl: ctx.build?.cachedUrl,
storybookUrl: ctx.build?.cachedUrl.replace(/iframe\.html.*$/, ''),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the .* at the end?

PS we also have a build.storybookUrl that we could request, perhaps could be more reliable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that to also strip off any query params (which would not work for the manager)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should never be any query params on cachedUrl I think, but can't hurt to guard against it I suppose.

};
}

Expand Down