Fix storybookUrl by removing iframe.html suffix
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
bug
tmeasday
reviewed
Feb 11, 2022
| @@ -107,7 +107,7 @@ async function runChromatic(options): Promise<Output> { | |||
| url: ctx.build?.webUrl, | |||
| code: ctx.exitCode, | |||
| buildUrl: ctx.build?.webUrl, | |||
| storybookUrl: ctx.build?.cachedUrl, | |||
| storybookUrl: ctx.build?.cachedUrl.replace(/iframe\.html.*$/, ''), | |||
There was a problem hiding this comment.
Why the .* at the end?
PS we also have a build.storybookUrl that we could request, perhaps could be more reliable?
There was a problem hiding this comment.
I added that to also strip off any query params (which would not work for the manager)
There was a problem hiding this comment.
There should never be any query params on cachedUrl I think, but can't hurt to guard against it I suppose.
ndelangen
changed the title
|
@ghengeveld WDYT? |
yannbf
approved these changes
Feb 17, 2022
ghengeveld
approved these changes
Feb 20, 2022
ghengeveld
changed the title
storybookUrl by removing iframe.html suffix
ghengeveld
deleted the
norbert/sb-104-github-action-storybookurl-output
branch
|
Released in 6.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the action's storybookUrl output, to NOT include
iframe.htmlas requested in #409