Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2469) Remove deprecated Chocolatey helper functions #2613

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Mar 3, 2022

Description Of Changes

This pull request removes the deprecated helper functions that was deprecated prior to v1.0.0 and scheduled for removal in said version.

Motivation and Context

To get rid of deprecated functions as much as we can.

Testing

  1. Run build.bat to ensure that the build and unit tests has not been broken

Change Types Made

  • Bug fix (non-breaking change)
  • Feature / Enhancement (non-breaking change)
  • Breaking change (fix or feature that could cause existing functionality to change)
  • PowerShell code changes.

Related Issue

Fixes #2469

Change Checklist

  • Requires a change to the documentation (Additional issue on docs repository is available).
  • Documentation has been updated
  • Tests to cover my changes, have been added
  • All new and existing tests passed.
  • PowerShell v2 compatibility checked.

@AdmiringWorm AdmiringWorm self-assigned this Mar 3, 2022
@AdmiringWorm AdmiringWorm requested a review from gep13 March 3, 2022 14:54
@AdmiringWorm AdmiringWorm force-pushed the 2469-Remove-deprecated-Chocolatey-helper-functions branch 2 times, most recently from c53840d to 44caa98 Compare March 7, 2022 14:52
This function was deprecated before, and should now be
removed for v1.0.0.
This commit removes this cmdlet.
This function was deprecated is meant to be removed
in v1.0.0.
This commit removes this function, and all usages of
the functions. There may need to be updates in other
locations outside of this repository that do similar
changes.
This commit removes the deprecated cmdlet
Write-ChocolateyFailure.
This cmdlet was deprecated for v1.0.0 and are
now removed with this commit.
This commit removes the deprecated cmdlet
Install-ChocolateyDesktopLink.
This cmdlet was deprecated before v1.0.0 and pending
removal for v1.0.0.
@gep13 gep13 force-pushed the 2469-Remove-deprecated-Chocolatey-helper-functions branch from 44caa98 to b3c562a Compare March 8, 2022 07:53
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 6eaed42 into chocolatey:develop Mar 8, 2022
@gep13
Copy link
Member

gep13 commented Mar 8, 2022

@AdmiringWorm woo hoo! 🎉 Thanks for getting these removed! Great to see these things being tidied up!

@AdmiringWorm AdmiringWorm deleted the 2469-Remove-deprecated-Chocolatey-helper-functions branch March 8, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated Chocolatey helper functions
2 participants