Merge pull request #2613 from AdmiringWorm/2469-Remove-deprecated-Chocolatey-helper-functions

(#2469) Remove deprecated Chocolatey helper functions

Author: gep13

GenerateDocs.ps1

@@ -57,13 +57,6 @@ These functions call other functions and many times may be the only thing you ne
 * [Install-ChocolateyPowershellCommand](xref:install-chocolateypowershellcommand)
 * [Install-ChocolateyVsixPackage](xref:install-chocolateyvsixpackage)
 
-## Error / Success Functions
-
-* [Write-ChocolateySuccess](xref:write-chocolateysuccess) - **DEPRECATED**
-* [Write-ChocolateyFailure](xref:write-chocolateyfailure) - **DEPRECATED**
-
-You really don't need a try catch with Chocolatey PowerShell files anymore.
-
 ## More Functions
 
 ### Administrative Access Functions
@@ -86,13 +79,10 @@ These are the functions from above as one list.
 
 * [Install-ChocolateyZipPackage](xref:install-chocolateyzippackage)
 * [Install-ChocolateyPowershellCommand](xref:install-chocolateypowershellcommand)
-* [Write-ChocolateySuccess](xref:write-chocolateysuccess)
-* [Write-ChocolateyFailure](xref:write-chocolateyfailure)
 * [Get-ChocolateyWebFile](xref:get-chocolateywebfile)
 * [Get-ChocolateyUnzip](xref:get-chocolateyunzip)
 * [Install-ChocolateyPath](xref:install-chocolateypath) - when specifying user path
 * [Install-ChocolateyEnvironmentVariable](xref:install-chocolateyenvironmentvariable) - when specifying user path
-* [Install-ChocolateyDesktopLink](xref:install-chocolateydesktoplink) - **DEPRECATED** - see [Install-ChocolateyShortcut](xref:install-chocolateyshortcut)
 * [Install-ChocolateyPinnedTaskBarItem](xref:install-chocolateypinnedtaskbaritem)
 * [Install-ChocolateyShortcut](xref:install-chocolateyshortcut) - v0.9.9+
 * [Update-SessionEnvironment](xref:update-sessionenvironment)

src/chocolatey.resources/chocolatey.resources.csproj

@@ -69,7 +69,6 @@
     <EmbeddedResource Include="helpers\functions\Get-VirusCheckValid.ps1" />
     <EmbeddedResource Include="helpers\functions\Get-WebFile.ps1" />
     <EmbeddedResource Include="helpers\functions\Get-WebHeaders.ps1" />
-    <EmbeddedResource Include="helpers\functions\Install-ChocolateyDesktopLink.ps1" />
     <EmbeddedResource Include="helpers\functions\Install-ChocolateyEnvironmentVariable.ps1" />
     <EmbeddedResource Include="helpers\functions\Install-ChocolateyExplorerMenuItem.ps1" />
     <EmbeddedResource Include="helpers\functions\Install-ChocolateyFileAssociation.ps1" />
@@ -85,9 +84,6 @@
     <EmbeddedResource Include="helpers\functions\Uninstall-ChocolateyPackage.ps1" />
     <EmbeddedResource Include="helpers\functions\UnInstall-ChocolateyZipPackage.ps1" />
     <EmbeddedResource Include="helpers\functions\Update-SessionEnvironment.ps1" />
-    <EmbeddedResource Include="helpers\functions\Write-ChocolateyFailure.ps1" />
-    <EmbeddedResource Include="helpers\functions\Write-ChocolateySuccess.ps1" />
-    <EmbeddedResource Include="helpers\functions\Write-FileUpdateLog.ps1" />
     <EmbeddedResource Include="redirects\choco.exe.ignore" />
     <EmbeddedResource Include="redirects\chocolatey.exe.ignore" />
     <EmbeddedResource Include="redirects\cinst.exe.ignore" />

src/chocolatey.resources/helpers/functions/Install-ChocolateyDesktopLink.ps1

@@ -110,9 +110,6 @@ Install-ChocolateyShortcut `
   -RunAsAdmin `
   -PinToTaskbar
 
-.LINK
-Install-ChocolateyDesktopLink
-
 .LINK
 Install-ChocolateyExplorerMenuItem
 

src/chocolatey.resources/helpers/functions/Install-ChocolateyShortcut.ps1

@@ -1,20 +1,13 @@
 $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)"
 
-try {
-  "simple file" | Out-File "$toolsDir\simplefile.txt" -force
+"simple file" | Out-File "$toolsDir\simplefile.txt" -force
 
-  Write-Output "This is $packageName v$packageVersion being installed to `n '$packageFolder'."
-  Write-Host "PowerShell Version is '$($PSVersionTable.PSVersion)' and CLR Version is '$($PSVersionTable.CLRVersion)'."
-  Write-Host "Execution Policy is '$(Get-ExecutionPolicy)'."
-  Write-Host "PSScriptRoot is '$PSScriptRoot'."
-  Write-Debug "A debug message."
-  Write-Verbose "Yo!"
-  Write-Warning "A warning!"
-  Write-Error "Oh no! An error"
-  throw "We had an error captain!"
-
-  Write-ChocolateySuccess "$packageName"
-} catch {
-  Write-ChocolateyFailure "$packageName" "$($_.Exception.Message)"
-  throw
-}
+Write-Output "This is $packageName v$packageVersion being installed to `n '$packageFolder'."
+Write-Host "PowerShell Version is '$($PSVersionTable.PSVersion)' and CLR Version is '$($PSVersionTable.CLRVersion)'."
+Write-Host "Execution Policy is '$(Get-ExecutionPolicy)'."
+Write-Host "PSScriptRoot is '$PSScriptRoot'."
+Write-Debug "A debug message."
+Write-Verbose "Yo!"
+Write-Warning "A warning!"
+Write-Error "Oh no! An error"
+throw "We had an error captain!"