Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Enable Passing Objects to --custom-transforms/-fct #1698

Draft
wants to merge 3 commits into
base: master-deprecated
Choose a base branch
from

Conversation

seldridge
Copy link
Member

This lets a user pass an object (with a trailing $) as a command line custom transform, e.g., this lets a user do the following:

firrtl -i Foo.fir -fct firrtl.passes.InferTypes$

Dependencies

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Pure API expansion of the FIRRTL command line interface.

Backend Code Generation Impact

None

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

Change the type of the transform stored in a
RunFirrtlTransformAnnotation from a Transform object to a
Dependency[Transform]. This enables using either a class or an object
dependency.

Backwards compatibility is preserved with a deprecated apply method
for wrapping a Transform object in a Dependency.

Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant