Remove Deprecated Driver #1475
Closed
Remove Deprecated Driver #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
driver-cleanup
branch
4 times, most recently
from
9d2fa0c to
9be84c9
Compare
seldridge
force-pushed
the
driver-cleanup
branch
from
9be84c9 to
a78b67f
Compare
seldridge
force-pushed
the
driver-cleanup
branch
2 times, most recently
from
44f58dc to
901f68e
Compare
This was referenced Jun 18, 2020
seldridge
force-pushed
the
driver-cleanup
branch
from
901f68e to
89043a7
Compare
|
So, it's not so simple... For this to be merged, both testers and testers2 need to migrate to Stage/Phase and likely go full a full deprecation cycle. I'm converting this to a draft and factoring out the pieces that can merged independently of fully removing the driver. |
seldridge
force-pushed
the
driver-cleanup
branch
from
89043a7 to
437ec13
Compare
Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
Remove the private[chisel3] internals of the DriverCompatibility object. Add a deprecation notice that DriverCompatibility will be removed in Chisel 3.4. Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
driver-cleanup
branch
from
437ec13 to
f1c0ea7
Compare
|
Fixed via #1730. Amazing work @sequencer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
chisel3.Driverand organize tests for FIRRTL 1.4 / Chisel 3.4.ChiselStagemethods are used instead of those in theBackendCompilationUtilitiestrait, e.g., for elaborationextractCause[A <: Throwable : ClassTag], is added that rethrows a nestedAif it existsextractCauseutility is used to convert tests that expected an exception, but now get aStageError.chisel3.Driverare removedDriverare removedDriverinfrastructure (e.g.,ChiselExecutionResult) is deprecatedRelated issue:
extractCauseType of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
tl;dr: