asBools, asBool, and chained apply on asBools #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
added
API Modification
Bugfix
edwardcwang
reviewed
Nov 21, 2018
| @@ -78,6 +78,15 @@ abstract class Element extends Data { | |||
| */ | |||
| private[chisel3] sealed trait ToBoolable extends Element { | |||
|
|
|||
| /** Casts this $coll to a [[Bool]] | |||
There was a problem hiding this comment.
Is $coll meant to be substituted?
There was a problem hiding this comment.
@seldridge added this when he improved the ScalaDoc, I just copied it from toBool
ducky64
approved these changes
Nov 29, 2018
| width match { | ||
| case KnownWidth(1) => this(0) | ||
| case _ => throwException(s"can't covert UInt<$width> to Bool") | ||
| case _ => throwException(s"can't covert ${this.getClass.getSimpleName}$width to Bool") |
There was a problem hiding this comment.
Perhaps a future todo: add a function to render a data type as a string. This looks like it's asking for something at a higher level of abstraction and more general that should exist, but doesn't.
There was a problem hiding this comment.
Agreed, I think a way to render unbound types as well as bound values in a more useful way would be very valuable. The whole UInt@4fd5e7a is pretty worthless most of the time
There was a problem hiding this comment.
Created a tracking issue for that in #953
|
retest this please |
The expanded version substituted in by the macro was misspelled, renamed from toBools -> do_toBools as expected by the macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
.asBools