Undeprecate log2Up and log2Down #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should not be deprecated until zero-width wires actually work
ducky64
approved these changes
Jul 6, 2018
|
Also maybe include a link to a tracking issue for zero width wires, so we can understand why these were undeprecated in the future, when we want to re-deprecate them? |
|
Yeah I think that is sensible, I'll file a meta tracking issue and add a link to it to the comments added here |
Add links to zero-width wire issue in places where deprecation warnings were removed awaiting full zero-width wire support
ucbjrl
pushed a commit
that referenced
this pull request
Jul 17, 2018
They should not be deprecated until zero-width wires actually work (cherry picked from commit 94be48d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They should not be deprecated until zero-width wires actually work. See chipsalliance/firrtl#530.
Obviously the better solution is to make zero-width wires fully work but it's been a year and it hasn't happened. Lots of people are using chisel3 now and are pretty annoyed by the deprecation warnings when they really can't switch to
log2Ceilandlog2Flooryet.Related issue:
People have reported problems with this #652 and more have complained to me directly.
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Undo the deprecation of log2Up and log2Down until zero-width wires work.