Add Instanitate.definition to get Definition from cache. #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
force-pushed
the
defination-cacheable
branch
from
232dbff to
1db52e9
Compare
sequencer
force-pushed
the
defination-cacheable
branch
2 times, most recently
from
cb097f1 to
88a4d81
Compare
sequencer
changed the title
sequencer
force-pushed
the
defination-cacheable
branch
from
88a4d81 to
006cd74
Compare
sequencer
commented
Apr 21, 2024
| } | ||
|
|
||
| private object internal { | ||
| // impl cannot be private, but it can be inside of a private object which hides it from the public | ||
|
|
||
| def instance[A <: BaseModule: c.WeakTypeTag](c: Context)(con: c.Tree): c.Tree = { |
There was a problem hiding this comment.
I have no idea on how to dedup these macro, since it transforms args... seek help from @jackkoenig
SpriteOvO
approved these changes
Apr 23, 2024
sequencer
added
the
Please Merge
|
|
sequencer
force-pushed
the
defination-cacheable
branch
from
d6c56c7 to
81d4cf7
Compare
jackkoenig
reviewed
Apr 25, 2024
| ): Instance[A] = Instance.do_apply(_defination(args, f))(sourceInfo) | ||
|
|
||
| /** This is not part of the public API, do not call directly! */ | ||
| def _defination[K, A <: BaseModule: ru.WeakTypeTag]( |
There was a problem hiding this comment.
Slight typo, should be _definition, here and below.
There was a problem hiding this comment.
Not a big deal, we just should fix before 7.0.0-M2/RC1!
There was a problem hiding this comment.
Sure I'll fix that after getting up tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dep on #4018
This issue is designed for the use case of OM, but also apply to the future linking flow.
The type of
Classshould always be deduped at chisel elaboration time, since for each elaboration, newly generatedClasshas a different type to previous one.Thus we need to force user to pass
Definitionfrom top to down though hierarchy. I think is a bad user experience. :(Generally, all OM
Classare cacheable since it only containing simple value or no values. This makes cache always work.Thus user only need to use
Instanitate.definition(new SomeOM)to elaborateSomeOMor fetchSomeOMfrom builder cache if possible.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.