Unify BaseModule.IO and chisel3.experimental.IO into chisel3.IO #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwachs5
reviewed
Nov 30, 2022
| * Internal API. | ||
| */ | ||
| def apply[T <: Data](iodef: => T)(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): T = { | ||
| val module = Module.currentModule.get // Impossible to fail |
There was a problem hiding this comment.
how is this impossible to fail?
There was a problem hiding this comment.
It definitely isn't but note that @adkian-sifive just moved this code. It probably was impossible back when the only way to call IO was via protected def defined on Module.
jackkoenig
approved these changes
Dec 1, 2022
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
(cherry picked from commit de25bf6) # Conflicts: # core/src/main/scala/chisel3/Module.scala
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
Mar 9, 2023
1. remove Cat from util chipsalliance/chisel#3062 2. remove experimental.IO chipsalliance/chisel#2863
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
Mar 9, 2023
1. remove Cat from util chipsalliance/chisel#3062 2. remove experimental.IO chipsalliance/chisel#2863
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
May 28, 2023
- remove experimental.IO chipsalliance/chisel#2863 - remove additional bracket - remove Chisel compatibility mode
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
May 29, 2023
- remove experimental.IO chipsalliance/chisel#2863 - remove bracket for fire() - remove Chisel compatibility mode
lordspacehog
pushed a commit
to lordspacehog/diplomacy_old_fork
that referenced
this pull request
Feb 7, 2024
- remove experimental.IO chipsalliance/chisel#2863 - remove bracket for fire() - remove Chisel compatibility mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
API Impact
chisel3.experimental.IOwill be deprecated and replaced bychisel3.IOBackend Code Generation Impact
N/A
Desired Merge Strategy
Release Notes
The
IOfromchisel3.experimental.IObeen deprecated in favor ofchisel3.IO.Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.