Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullModulePorts + Opaque Types Fix and Test #2845

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Nov 15, 2022

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

Fixes #2844, corrects the string IO names from fullModulePorts.

Backend Code Generation Impact

Unless verilog was being generated by reflecting upon DataMirror.fullModulePorts returned values, no changes to emitted verilog.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Fix #2844, corrects the string IO names from fullModulePorts.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mwachs5 mwachs5 added this to the 3.5.x milestone Nov 15, 2022
@jackkoenig jackkoenig merged commit 49feb08 into master Nov 15, 2022
@jackkoenig jackkoenig deleted the fullmoduleports-opaque branch November 15, 2022 05:13
mergify bot pushed a commit that referenced this pull request Nov 15, 2022
@mergify mergify bot added the Backported This PR has been backported label Nov 15, 2022
mergify bot added a commit that referenced this pull request Nov 15, 2022
(cherry picked from commit 49feb08)

Co-authored-by: Megan Wachs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataMirror.fullModulePorts and Opaque Types don't work as expected
3 participants