Have phases.Emitter name phases.Convert as a dependent #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
seldridge
approved these changes
Apr 14, 2020
|
This should be fine as a temporary fix for 3.2.x. All this should be fixed up after the "How To Serialize" series (firrtl#1277 and chisel#1405) is merged. Currently this is slated as 3.4/1.4, so a 3.2.x fix makes sense. #1405 makes the change where |
seldridge
added
Bugfix
|
@davidbiancolin, the CLA bot doesn't think you've signed the CLA. |
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Pull out common test utilities into a separate package * Project a fat jar for test utilities Co-authored-by: Albert Magyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must be prefaced with i'm not at all sure this is the correct solution...
That said, under the current ordering constraints, the phase manager might elect to schedule the convert phase before the emitter phase, which removes the chisel circuit annotation before it can be processed by the emitter. Really i'm using dependent here more in "make-sure-i-run-before" sense, i'm not sure that's the right idea.
The underlying problem here is that certain phases need to run at some point during the lifetime of specific annotations and often it's not clear what that lifetime is, short of reading each phase. If an annotation is going to be used by multiple consumer passes, some of which might be outside of chisel's control, it may make sense to dedicate an entire pass to the removal of certain annotations if we choose to remove them at all (ie. RemoveChiselCircuitAnnotationPhase) -- after all, another possible fix here is simply not to delete the annotation (and potentially mark it so it is not serialized).
Type of change: bug report
Impact: no functional change
Release Notes
Have the emitter Phase name the Convert phase as a dependent.