Switch to HowToSerialize for Emission #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
seldridge
force-pushed
the
how-to-serialize
branch
3 times, most recently
from
f82abf0 to
99bc955
Compare
seldridge
force-pushed
the
how-to-serialize
branch
from
99bc955 to
4eb7e9f
Compare
seldridge
force-pushed
the
how-to-serialize
branch
3 times, most recently
from
308e16b to
19844a0
Compare
|
@jackkoenig or @ekiwi-sifive: Can I get a review on this one? Builds are going to be busted until this goes through since chipsalliance/firrtl#1277 was merged. |
Change ChiselStage helper methods for emitting FIRRTL (emitFirrtl) and Verilog (emitVerilog) to look for Circuit and Verilog annotations instead of DeletedAnnotations. This is needed after migrating to the CustomFileEmission mixin in FIRRTL where FIRRTL will no longer delete emitter annotations. Signed-off-by: Schuyler Eldridge <[email protected]>
Removes the explicit chisel3.phases.Emitter and instead does emission with a CustomFileEmission mixin to ChiselCircuitAnnotation. This then prevents the need for passing around DeletedAnnotations. As a consequence, I removed an unnecessary run of a second Converter in the Driver. Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
how-to-serialize
branch
from
19844a0 to
76831ef
Compare
seldridge
added
the
Please Merge
seldridge
force-pushed
the
how-to-serialize
branch
from
e3d6562 to
fb030af
Compare
ekiwi
approved these changes
Aug 12, 2020
seldridge
force-pushed
the
how-to-serialize
branch
from
fb030af to
76831ef
Compare
|
In the spirit of expediency, I'm going to revert this to the passing commit. I'll open a new PR to add deprecations and clean things up (what I was adding to the PR before everyone realized the build was broken...). |
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Update scalatest to 3.1.1 * Update scalatest to 3.1.1 * Update scalatest to 3.1.1 Co-authored-by: Jim Lawson <[email protected]> Co-authored-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
chisel3.stage.phases.Emitterand moves its emission logic into theChiselCircuitAnnotation. This uses the newHowToSerializemix-in provided by chipsalliance/firrtl#1277.A consequence of this is that there is no longer a need for generating
DeletedAnnotations and for introspection ofDeletedAnnotations to determine an execution result or a view of some sequence of annotations.Related issue: Depends on chipsalliance/firrtl#1277
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes