Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundancy code #1296

Merged
merged 7 commits into from
Jan 25, 2020
Merged

Conversation

colin4124
Copy link
Contributor

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

super.nameIds has already added io, clock and reset in names by reflection.

protected override def nameIds(rootClass: Class[_]): HashMap[HasId, String] = {
  val names = super.nameIds(rootClass)

  // Allow IO naming without reflection
  println(s"{names(io)}")
  println(s"{names(clock)}")
  println(s"{names(reset)}")

  names.put(io, "io")
  names.put(clock, "clock")
  names.put(reset, "reset")

  names
}

Output:

[info] [0.005] Elaborating design...
io
clock
reset
[info] [1.177] Done elaborating.
Total FIRRTL Compile Time: 740.5 ms

@colin4124 colin4124 requested a review from a team as a code owner January 5, 2020 14:56
@chick
Copy link
Contributor

chick commented Jan 21, 2020

@colin4124 Can you update this. It looks like it is out of date

chick and others added 3 commits January 23, 2020 01:07
…ability.

The BitPat.parse factory though did not remove these from the returned count.
This fixes that adds whitespace and underscores to the unit tests
This is an updated vesion of Chisel PR chipsalliance#1069
@azidar azidar added this to the 3.2.X milestone Jan 25, 2020
@azidar azidar added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 25, 2020
@mergify mergify bot merged commit 160e019 into chipsalliance:master Jan 25, 2020
mergify bot pushed a commit that referenced this pull request Jan 25, 2020
* Remove redundancy code

* Remove blank line

* BitPat supports whitespace and underscores, presumably for human readability.
The BitPat.parse factory though did not remove these from the returned count.
This fixes that adds whitespace and underscores to the unit tests
This is an updated vesion of Chisel PR #1069

Co-authored-by: Chick Markley <[email protected]>
Co-authored-by: Jim Lawson <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 160e019)
@mergify mergify bot added the Backported This PR has been backported label Jan 25, 2020
mergify bot added a commit that referenced this pull request Jan 25, 2020
* Remove redundancy code

* Remove blank line

* BitPat supports whitespace and underscores, presumably for human readability.
The BitPat.parse factory though did not remove these from the returned count.
This fixes that adds whitespace and underscores to the unit tests
This is an updated vesion of Chisel PR #1069

Co-authored-by: Chick Markley <[email protected]>
Co-authored-by: Jim Lawson <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 160e019)

Co-authored-by: Leway Colin <[email protected]>
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
* transform InlineBitExtractions

* InlineNotsTransform, InlineBitExtractionsTransform: inputForm/outputForm = UnknownForm

* clean up some minor redundancies from Adam review

* clarifications from Seldrige review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants