Skip to content

Commit

Permalink
Remove redundancy code (#1296)
Browse files Browse the repository at this point in the history
* Remove redundancy code

* Remove blank line

* BitPat supports whitespace and underscores, presumably for human readability.
The BitPat.parse factory though did not remove these from the returned count.
This fixes that adds whitespace and underscores to the unit tests
This is an updated vesion of Chisel PR #1069

Co-authored-by: Chick Markley <[email protected]>
Co-authored-by: Jim Lawson <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 160e019)
  • Loading branch information
colin4124 authored and mergify-bot committed Jan 25, 2020
1 parent 3c20ed9 commit 0beac0b
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions chiselFrontend/src/main/scala/chisel3/RawModule.scala
Original file line number Diff line number Diff line change
Expand Up @@ -184,17 +184,6 @@ package internal {
// Allow access to bindings from the compatibility package
protected def _compatIoPortBound() = portsContains(io)// scalastyle:ignore method.name

protected override def nameIds(rootClass: Class[_]): HashMap[HasId, String] = {
val names = super.nameIds(rootClass)

// Allow IO naming without reflection
names.put(io, "io")
names.put(clock, "clock")
names.put(reset, "reset")

names
}

private[chisel3] override def namePorts(names: HashMap[HasId, String]): Unit = {
for (port <- getModulePorts) {
// This should already have been caught
Expand Down

0 comments on commit 0beac0b

Please sign in to comment.