Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Strawman RFC] Packages #1006

Closed
ducky64 opened this issue Jan 26, 2019 · 2 comments
Closed

[Strawman RFC] Packages #1006

ducky64 opened this issue Jan 26, 2019 · 2 comments
Assignees
Milestone

Comments

@ducky64
Copy link
Contributor

ducky64 commented Jan 26, 2019

From #994 and #998 it appears that some people actually import chisel3.core despite that being intended as an internal package with the public portions being exposed by alias in chisel3._. There was some discussion about whether this aliasing for separating public / internal APIs is useful, and whether we should just move things back into the chisel3 package directly.

Here's a simple mock proposal for what that could look like:

  • Move current chisel3.core contents that are public into chisel3.
  • Move parts of chisel3.core that are experimental into chisel3.experimental package (instead of aliasing into core in a package object)
  • Create a chisel3.core package object as a compatibility layer for the foolish.
  • Use chisel3.internals for any truly internal features.
  • Note that because we are moving objects, this will break binary compatibility. Probably should align on a major version.

Please poke holes in this strawman and improve upon it.


Type of issue: other enhancement

Impact: no functional change / API modification

Development Phase: request, (bad?) proposal

Other information

@schoeberl
Copy link
Contributor

schoeberl commented Jan 26, 2019 via email

@ducky64
Copy link
Contributor Author

ducky64 commented May 24, 2019

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants