nodemanager nodes: fix platform and tags info, add state to possible sort options #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
commented
May 5, 2020
| @@ -166,6 +166,7 @@ var nodesSortFields = map[string]string{ | |||
| "status": "LOWER(n.status)", | |||
| "manager": "LOWER(n.manager)", | |||
| "last_contact": "n.last_contact", | |||
| "state": "n.source_state", | |||
There was a problem hiding this comment.
leaving as draft til i get a test written for this
vjeffrey
commented
May 6, 2020
|
|
||
| return &manager.NodeMetadata{ | ||
| Uuid: node.EntityUuid, | ||
| Name: node.NodeName, | ||
| PlatformName: node.Platform, | ||
| PlatformName: node.PlatformFamily, |
There was a problem hiding this comment.
maybe we want to eventually go to just sending the platform full field? for now, i switched it to using family for consistency with compliance side of things, since it's sending name/version as two sep fields, and two sep fields is what nodemanager expects
There was a problem hiding this comment.
For our example CCR
The platform_family "rhel" is different than the platform "redhat". I don't know if this will be a problem.For this other example
the platform_family is "debian" but the platform is "ubuntu". That might be confusing to show "debian 18.04" for the platform when debian is only on version 10.There was a problem hiding this comment.
I think I have a solution 🤔
|
ill get this rebased |
added 8 commits
May 6, 2020 16:59
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
lancewf
approved these changes
May 6, 2020
Signed-off-by: Lance Finfrock <[email protected]>
vjeffrey
force-pushed
the
vj/platform-tags-state
branch
from
154753b to
0cd68bf
Compare
vjeffrey
commented
May 6, 2020
| @@ -355,6 +355,10 @@ func (ccr *ChefClientRun) CloudProvider() string { | |||
| return EmptyStringIfNil(cloud["provider"]) | |||
| } | |||
|
|
|||
| func (ccr *ChefClientRun) Platform() string { | |||
There was a problem hiding this comment.
oh i think this is from the rebase and no longer needed?
Signed-off-by: Victoria Jeffrey <[email protected]>
This was referenced Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
a few issues:
⛓️ Related Resources
#3515
👍 Definition of Done
platform information doesn't double up. tags are all sent over, including env. can filter by state.
👟 How to Build and Test the Change
go_update_component compliance-service
same for ingest-service
and nodemanager-service
send in some reports, e.g. load_compliance_reports
check the data returned by
api/v0/nodes, accessible at automate-url/nodes in the ui✅ Checklist
Aha! Link: https://chef.aha.io/features/SH-1780