one node view: issues

[vjeffrey]

User Story

we've created a basic (hidden) view in automate, at automate-url/nodes, that surfaces the data provided by the api/v0/nodes endpoint.

this issue is to track any issues we see with that data:

• platform version is sometimes doubled up

• manager field is blank for nodes that are attached to a chef server - we could fill this field in with the value of the chef server

• right now we send manager id in that manager field
• if it's a report coming in through ingest service, we at least know "chef" is the manager
• all of this logic is internal only so we can change it

• environment value should be added to the tags sent to nodemanager so we can show it

• nodes marked as terminated (from aws-ec2, for example) are not auto-deleted. should we auto-delete them?

• nodes attached to a manager (aws-ec2, for example) are not auto-deleted when deleting the manager, should we?

• running a scan job (not audit cookbook) on a node that has chef client on it would result in a duplicate node record

• supported sort fields: [last_contact manager name platform platform_version status] (need to add state)

Aha! Link: https://chef.aha.io/features/SH-1631

[vjeffrey]

wip https://github.com/chef/automate/tree/vj/nodes-fixes