[Automate-2950] Port introspection from v1 to v2 #3032

msorens · 2020-03-04T17:05:48Z

🔩 Description: What code changed, and why?

Relocates v1 endpoints to v2 endpoints in the gateway

Renamed
automate-gateway/api/authz/authz.proto
to
automate-gateway/api/iam/v2/introspect.proto
...along with associated request and response files.

⛓️ Related Resources

NA

👍 Definition of Done

Network requests for introspection now show up with a apis/iam/v2 path instead of api/v0/auth.

Integration tests work with v2 path:

# inspec exec inspec/a2-iam-v2-integration --controls=introspection-iam-v2-1

Profile: InSpec Automate Integration Profile for IAM v2 migration (a2-iam-v2-integration)
Version: 0.1.0
Target:  local://

  _  introspection-iam-v2-1: authz introspection with IAM v2
     _  introspect all returns what we expect
     _  introspect some returns what we expect
     _  introspect (single) with parameters returns what we expect

Had several buildkite failures to figure out, but finally got all tests here passing! 🎉

(Have not done anything with verify_private due to current issues there.)

👟 How to Build and Test the Change

rebuild components/automate-gateway

✅ Checklist

I have read the CONTRIBUTING document.
Tests added/updated?
Docs added/updated?
All commits have been signed-off for the Developer Certification of Origin.

Signed-off-by: michael sorens <[email protected]>

msorens · 2020-03-04T17:12:23Z

components/automate-gateway/api/api_test.go

-	_ "github.com/chef/automate/api/external/nodes/manager"
-	_ "github.com/chef/automate/api/external/secrets"
-	_ "github.com/chef/automate/components/automate-gateway/api/auth/teams"
-	_ "github.com/chef/automate/components/automate-gateway/api/authz"


Only actual change is deleting this line; introspection endpoints are now included on L24 (not visible here).

msorens · 2020-03-04T17:15:04Z

components/automate-gateway/api/iam/v2/introspect.proto

-package chef.automate.api.authz;
-option go_package = "github.com/chef/automate/components/automate-gateway/api/authz";
+package chef.automate.api.iam.v2;
+option go_package = "github.com/chef/automate/components/automate-gateway/api/iam/v2";


Now consistent with all the other v2 endpoints.

msorens · 2020-03-04T17:15:31Z

components/automate-gateway/api/iam/v2/introspect.proto

-  rpc IntrospectAll (authz.request.IntrospectAllReq) returns (authz.response.IntrospectResp) {
-    option (google.api.http).get = "/auth/introspect";
+  rpc IntrospectAll (IntrospectAllReq) returns (IntrospectResp) {
+    option (google.api.http).get = "/iam/v2/introspect";


Adjust the exposed endpoint paths to v2 paths here.

msorens · 2020-03-04T17:16:45Z

components/automate-gateway/gateway/services.go

@@ -351,7 +352,6 @@ func unversionedRESTMux(grpcURI string, dopts []grpc.DialOption) (http.Handler,
 		"gateway":              pb_gateway.RegisterGatewayHandlerFromEndpoint,
 		"legacy":               pb_legacy.RegisterLegacyDataCollectorHandlerFromEndpoint,
 		"license":              pb_license.RegisterLicenseHandlerFromEndpoint,
-		"authz":                pb_authz.RegisterAuthorizationHandlerFromEndpoint,


Remove from the /api/v0 top-level path component here; add to the /apis path component in L378 below.

msorens · 2020-03-04T17:17:06Z

components/automate-gateway/handler/iam/v2/introspect/introspect.go

-// NewAuthzServer creates a server with its client
-func NewAuthzServer(
+// NewServer creates a server with its client
+func NewServer(


Change consistent with other v2 components.

msorens · 2020-03-04T17:17:41Z

components/automate-ui/src/app/entities/userperms/userperms.requests.ts

@@ -18,19 +18,19 @@ export class UserPermsRequests {
  // Returns data for all *non-parameterized* endpoints
  // (i.e. endpoints like "/iam/v2/teams" but not "/iam/v2/users/{email}").
  public fetchAll(): Observable<UserPermsResponse> {
-    const url = `${env.auth_url}/introspect`;
+    const url = `${env.auth_v2_url}/introspect`;


Finally, retarget the UI to use the new v2 endpoints.

should this just be renamed auth_url (given our efforts to drop the "v2" wherever possible)?

or iam? since all our APIs now live under iam

Definitely--thanks!!

inspec/a2-iam-v2-integration/controls/introspection.rb

msorens · 2020-03-04T17:19:02Z

inspec/a2-iam-v2-integration/controls/introspection.rb

-            'put': false,
+          '/iam/v2/policies/foo': {
+            'get': true,
+            'put': true,


v2 policies have a different "footprint" from v1.

msorens · 2020-03-04T22:44:55Z

.bldr.toml

@@ -24,6 +24,7 @@ paths = [
  "api/config/shared/*",
  "api/interservice/pg_sidecar/*",
  "components/automate-gateway/api/authz/*",
+  "components/automate-gateway/api/iam/*",


Just like we have to regenerate from proto file changes, when there are actual endpoint changes this may impact the bldr config, so generate_bldr_config regenerates this file.

msorens · 2020-03-04T22:46:12Z

components/automate-cli/pkg/client/apiclient/apiclient.go

@@ -10,7 +10,6 @@ import (
 	client_type "github.com/chef/automate/components/automate-cli/pkg/client"


automate-cli failed the build with a mysterious message:

cannot load github.com/chef/automate/components/automate-gateway/api/: no Go source files

Tracked that down to this handful of files needing the old path removed (introspection is now under automate-gateway/api/iam/v2)

Signed-off-by: michael sorens <[email protected]>

Starting with ` rebuild components/automate-cli/`, the error was: build github.com/chef/automate/components/automate-gateway/api/authz: cannot load github.com/chef/automate/components/automate-gateway/api/authz: no Go source files Traced that back to the same failure with just `make build` in the automate-cli directory, then to the same failure with just this: go build github.com/chef/automate/components/automate-cli/cmd/chef-automate Searching for api/authz in the cli directory led me to the files in this commit. Signed-off-by: michael sorens <[email protected]>

The "repo health" task in buildkite failed saying: ``` The bldr config appears to be out of date! To fix this, run: hab studio run "source .studiorc && generate_bldr_config" ``` Ran the fix: # install_if_missing core/go go # generate_bldr_config Signed-off-by: michael sorens <[email protected]>

components/automate-gateway/handler/iam/v2/introspect/introspect_test.go

components/automate-gateway/api/api_test.go

components/automate-gateway/gateway/services.go

inspec/a2-iam-v2-integration/controls/introspection.rb

blakestier

I had some nits about naming, but looks good!

bcmdarroch · 2020-03-05T17:20:40Z

components/automate-gateway/api/authz/pairs/pairs.go

@@ -8,7 +8,7 @@ import (
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"

-	gwAuthzRes "github.com/chef/automate/components/automate-gateway/api/authz/response"
+	gwAuthzRes "github.com/chef/automate/components/automate-gateway/api/iam/v2/response"


I was thinking we would move these files under authz under iam as well. otherwise i'm not sure what the distinction between authz and iam is at this point

As you said, I am going to do this in a follow-up PR. 👍

bcmdarroch

One change I was expecting was that all the files under authz/ (i.e. components/automate-gateway/api/authz/pairs/pairs.go and components/automate-gateway/api/authz/policy/policy.go) would move under iam/.
I'm guessing there might be lots of ripple changes caused by that, so I'm ok with making it a follow-up.

Signed-off-by: michael sorens <[email protected]>

* Remove IAM V1 conditionals from the UI and Cypress (#2753) * UI unit test cleanup post-merge of master Signed-off-by: michael sorens <[email protected]> * UI unit test cleanup post-merge of master Signed-off-by: michael sorens <[email protected]> * [Automate-1890] gateway v1 scrub (#2796) * [automate-2857] Update user service to teams v2 client (#2860) * Add method for proto parity Adding PurgeUserMembership to allow replacing the v1 team client with a v2 version. Signed-off-by: michael sorens <[email protected]> * Switch v1 team client to v2 team client Signed-off-by: michael sorens <[email protected]> * Implement necessary method for the revised interface Signed-off-by: michael sorens <[email protected]> * Update bldr.toml Removed dependency required rerunning `generate_bldr_config` Signed-off-by: michael sorens <[email protected]> * Correct admins team name per feedback Signed-off-by: michael sorens <[email protected]> * [automate-2720] IAM force upgrade migrations 🎉 (#2793) * Added general structure and TODOs for how to migrate up to the point of force upgrade Copied over code from migrator.go because we can't use the generic version anymore. Migrating up to the last SQL schema migration before we want to force upgrade. Started porting MigrateToV2 GRPC function over to the migration code. Signed-off-by: Tyler Cloke <[email protected]> * Remove ApplyV2DataMigrations db function and finish applying any data_migrations as part of the post-force-upgrade process Signed-off-by: Tyler Cloke <[email protected]> * Ported creation of default roles for v1 force upgrade Signed-off-by: Tyler Cloke <[email protected]> * Port defaultPolicies Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Port CreatePolicy Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Port code we might need for legacy migration Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * WIP Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Everything is compiling Signed-off-by: Tyler Cloke <[email protected]> * Added force_upgrade_status to only run force upgrade once Signed-off-by: Tyler Cloke <[email protected]> * Remove UpgradeToV2 from cli/gateway Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove auto-upgrade from studio Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Record migration status for versioning Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Rename constant Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove unused migration Signed-off-by: Tyler Cloke <[email protected]> * Use migration status to control migration logic Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Do TODOs Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove migration-related server code Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Updated our use of migration_status and cleaned up file layout Signed-off-by: Tyler Cloke <[email protected]> * Fixed variable name Signed-off-by: Tyler Cloke <[email protected]> * It working Signed-off-by: Tyler Cloke <[email protected]> * Initial porting work for tests Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Working on db tests Signed-off-by: Tyler Cloke <[email protected]> * It's passsssing Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Legacy Policy test Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Does not migrate legacy pols w/o subjs Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Legacy policies Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Migrates only valid v1 policies Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Simply log unmigrated policies These were already invalid in v1. No big deal if they aren't migrated. Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Add comment Signed-off-by: Tyler Cloke <[email protected]> * Renames/cleanup Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove ResetToV1 from gateway Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Updates bldr.toml Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Compilation errors from server change Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * remove resettov1 Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Fix :allthethings: Signed-off-by: Tyler Cloke <[email protected]> * Linting Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Trying to get CI happy Signed-off-by: Tyler Cloke <[email protected]> * Remove upgrade-to-v2 cmd Signed-off-by: Tyler Cloke <[email protected]> * Remove upgrade-to-v2 Signed-off-by: Tyler Cloke <[email protected]> * No longer have PreconditionFailed to tell v1 requests the gateway is in v2 mode. Just always use v2. Signed-off-by: Tyler Cloke <[email protected]> * Hopefully tests pass now Signed-off-by: Tyler Cloke <[email protected]> * Bldr config Signed-off-by: Tyler Cloke <[email protected]> * Add deny for infra:ingest:* to default policy migration Signed-off-by: Tyler Cloke <[email protected]> * Delete extra comment Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * add clarity to func Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Only migrate v1 policies on upgrade Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Review comments Signed-off-by: Tyler Cloke <[email protected]> * Update components/authz-service/storage/postgres/postgres.go Co-Authored-By: M Sorens <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Update components/authz-service/storage/postgres/migration/migration.go Co-Authored-By: M Sorens <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Update components/authz-service/storage/postgres/migration/migration.go Co-Authored-By: M Sorens <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Last review comments Signed-off-by: Tyler Cloke <[email protected]> Co-authored-by: Tyler Cloke <[email protected]> Co-authored-by: M Sorens <[email protected]> * [automate-2930] Fix NATS gateway test errors related to v2 force upgrade (#2933) * Add some logging around forced migration (#2938) * [automate-2861] Update authn service to teams v2 client (#2875) * [automate-2876] Update automate-deployment to teams v2 client (#2877) * Change IAM docs to focus on IAM v2 (#2715) * combine iamv1 pages into 1 Signed-off-by: susanev <[email protected]> * change users, teams, api tokens to iam v2 Signed-off-by: susanev <[email protected]> * added pages for policies, projects, roles Signed-off-by: susanev <[email protected]> * Copyedits and edits for clarity Signed-off-by: Mary Jinglewski <[email protected]> Co-authored-by: mjingle <[email protected]> Co-authored-by: susanev <[email protected]> * Auth 2926/teams v2 migrations (#2934) * Move operator team rename into schema migs Signed-off-by: Blake Johnson <[email protected]> * Integrate cli migration into schema migration Signed-off-by: Blake Johnson <[email protected]> * Remove datamigrations Signed-off-by: Blake Johnson <[email protected]> * Rename migration Signed-off-by: Blake Johnson <[email protected]> * Remove refs to datamigration Signed-off-by: Blake Johnson <[email protected]> * Remove refs to upgrade/reset iam * Cleanup after merge-from-master * Regenerate from protos after merge-from-master compile_go_protobuf_component automate-gateway && compile_go_protobuf_component api Signed-off-by: michael sorens <[email protected]> * Auth 2867/remove v1 tokens gateway apis (#2970) * remove tokens (v1) proto Signed-off-by: Blake Johnson <[email protected]> * Remove v1 tokens client Signed-off-by: Blake Johnson <[email protected]> * Modify UI to only use tokens v2 path Signed-off-by: Blake Johnson <[email protected]> * Update docs Signed-off-by: Blake Johnson <[email protected]> * Bright more files up to v2 for tokens Signed-off-by: Blake Johnson <[email protected]> * Update dev helper Signed-off-by: Blake Johnson <[email protected]> * Update docs Signed-off-by: Blake Johnson <[email protected]> * Remove v1 handler Signed-off-by: Blake Johnson <[email protected]> * Update bldr config Signed-off-by: Blake Johnson <[email protected]> * Remove v1 mock Signed-off-by: Blake Johnson <[email protected]> * remove v2 allusions Signed-off-by: Blake Johnson <[email protected]> * Revert docs change Signed-off-by: Blake Johnson <[email protected]> * [AUTOMATE-2866] Remove v1 users APIs from gateway (#2922) Signed-off-by: Tyler Cloke <[email protected]> * Fix force-upgrade merge conflicts (#2981) * Regenerate from protos after merge hab studio: compile_all_protobuf_components components/automate-chef-io: make sync_swagger_files Signed-off-by: michael sorens <[email protected]> * [automate-2868] Remove v1 policies (#2988) * [Automate-2950] Port introspection from v1 to v2 (#3032) * Relocate introspection protos to v2 Signed-off-by: michael sorens <[email protected]> * Rewire proto files together Signed-off-by: michael sorens <[email protected]> * Change exposed endpoints to v2 Signed-off-by: michael sorens <[email protected]> * Regenerate from protos Signed-off-by: michael sorens <[email protected]> * Relocate introspection endpoints to v2 Signed-off-by: michael sorens <[email protected]> * Rewire go files together Signed-off-by: michael sorens <[email protected]> * Change UI calls to v2 Signed-off-by: michael sorens <[email protected]> * Convert v1 integration test to v2 Signed-off-by: michael sorens <[email protected]> * Resolve path changes in cli component Starting with ` rebuild components/automate-cli/`, the error was: build github.com/chef/automate/components/automate-gateway/api/authz: cannot load github.com/chef/automate/components/automate-gateway/api/authz: no Go source files Traced that back to the same failure with just `make build` in the automate-cli directory, then to the same failure with just this: go build github.com/chef/automate/components/automate-cli/cmd/chef-automate Searching for api/authz in the cli directory led me to the files in this commit. Signed-off-by: michael sorens <[email protected]> * Regenerate bldr.toml The "repo health" task in buildkite failed saying: ``` The bldr config appears to be out of date! To fix this, run: hab studio run "source .studiorc && generate_bldr_config" ``` Ran the fix: # install_if_missing core/go go # generate_bldr_config Signed-off-by: michael sorens <[email protected]> * Delete v1 auth URL in UI Signed-off-by: michael sorens <[email protected]> * Replace auth_v2_url with iam_url in UI Signed-off-by: michael sorens <[email protected]> * Apply assorted review feedback Signed-off-by: michael sorens <[email protected]> * remove v1 team APIs from gateway & update dependent integration tests (#2952) * gateway: delete v1 team protos * gateway: drop v1 team stuff wherever it's imported * cli: use v2 teams client everywhere Signed-off-by: Brenna Hewer-Darroch <[email protected]> * [automate-2914] force-upgrade integration scenario: v1 -> v2 with migrated legacy policies (#2935) * v1 to force-upgrade v2 integration test reorganized all the IAM inspec tests Signed-off-by: Brenna Hewer-Darroch <[email protected]> Co-authored-by: Blake Johnson <[email protected]> Co-authored-by: M Sorens <[email protected]> * [Automate-2987] legacy ingest policy fix (#3044) * migration: any "{infra:ingest:*}" action is now "{ingest:*}" * update force-upgrade delete the "deny users infra:ingest" statement in infra legacy policy swap "infra:ingest:*" for "ingest:*" in ingest legacy policy * legacy policy migration testing Co-authored-by: Blake Johnson <[email protected]> Co-authored-by: Brenna Hewer-Darroch <[email protected]> * Resync bldr.toml generate_bldr_config Signed-off-by: michael sorens <[email protected]> * [automate-2916] v2 with no legacy policies -> force-upgrade to latest v2 integration test (#3009) * add v2 with no legacy force-upgrade to v2 we want to make sure that customers currently using v2 without v1 legacy policies are not disrupted by the force-upgrade. v1 legacy policies should not reappear. Signed-off-by: Brenna Hewer-Darroch <[email protected]> * [automate-2917] v2 with legacy policies -> force-upgrade to latest v2 integration test (#3008) * add force-upgrade v2 from v2 with legacy integration test we want to ensure that customers currently using IAM v2 are not disrupted by the force-upgrade Signed-off-by: Brenna Hewer-Darroch <[email protected]> * Vanished teams on force-upgrade (#3102) * Robust Deprecation of IAM v1 (#3104) * Robust Deprecation of v1 Signed-off-by: kagarmoe <[email protected]> * Deprecation on nav * Deprecation on nav Signed-off-by: kagarmoe <[email protected]> * Incorporates feedback Signed-off-by: kagarmoe <[email protected]> * Use feature branch iam-v2-overview.md Signed-off-by: kagarmoe <[email protected]> * Improve verb tense in IAM v2 Overview doc (#3033) * Improve verb tense in IAM v2 Overview doc Signed-off-by: Mary Jinglewski <[email protected]> * Edit progress so far Signed-off-by: Mary Jinglewski <[email protected]> * Incorporate Feedback Signed-off-by: Mary Jinglewski <[email protected]> * Active tense polishing Signed-off-by: Mary Jinglewski <[email protected]> * removes iam v2 from body Signed-off-by: kagarmoe <[email protected]> * Fix spaces Signed-off-by: kagarmoe <[email protected]> Co-authored-by: kagarmoe <[email protected]> * Revert "Improve verb tense in IAM v2 Overview doc (#3033)" (#3134) This reverts commit 746d6ea. * [automate-3065] Remove v1 authz storage (#3111) * fixes bad link Signed-off-by: kagarmoe <[email protected]> * Fix iam db migration tests to work locally (#3155) Signed-off-by: Tyler Cloke <[email protected]> * Revert "Revert "Improve verb tense in IAM v2 Overview doc (#303… (#3145) * Merge fix Signed-off-by: michael sorens <[email protected]> * [automate-3066] Delete authz v1 server code (#3146) * [automate-1886] farewell chef-automate admin-token (#3188) * chef-automate admin-token is no more Co-authored-by: Brenna Hewer-Darroch <[email protected]> Co-authored-by: Mary Jinglewski <[email protected]> * [automate-2710] Remove system:* perms, modify infra:* perms (#3148) * Update roles to have infra:nodes/nodeManagers over infra:* Signed-off-by: Blake Johnson <[email protected]> * Update roles to not have system access Signed-off-by: Blake Johnson <[email protected]> * Update docs with system change Signed-off-by: Blake Johnson <[email protected]> * update sql readme Signed-off-by: Blake Johnson <[email protected]> * Refactor query to work w/o policy Signed-off-by: Blake Johnson <[email protected]> * Add telemetry perms into default system policies Signed-off-by: Blake Johnson <[email protected]> * Update tests Signed-off-by: Blake Johnson <[email protected]> * Remove non-existent action for telemetry Signed-off-by: Blake Johnson <[email protected]> * remove (in tests) permission to request license to roles Signed-off-by: Blake Johnson <[email protected]> * Modify integration script Signed-off-by: Blake Johnson <[email protected]> * Add comments Signed-off-by: Blake Johnson <[email protected]> * Adds applications to roles Signed-off-by: Blake Johnson <[email protected]> * [Automate-2950] port introspection, wave two (#3050) * Update proto generation for v2-only Signed-off-by: michael sorens <[email protected]> * Remove v2 distinction in the generated code Signed-off-by: michael sorens <[email protected]> * Remove v1 protoc generation Signed-off-by: michael sorens <[email protected]> * Remove v2 from the generated pb file name Signed-off-by: michael sorens <[email protected]> * Correct path * Manual cleanup to get things building Not sure why these were not covered by the regeneration but was getting this error until I found and removed these: $ make build build github.com/chef/automate/components/automate-gateway/cmd/automate-gateway: cannot load github.com/chef/automate/components/automate-gateway/authz/policy_v2: open /Users/msorens/code/go/src/github.com/chef/automate/components/automate-gateway/authz/policy_v2: no such file or directory Signed-off-by: michael sorens <[email protected]> * Regenerate bldr.toml Signed-off-by: michael sorens <[email protected]> * Relocate pairs and policy under iam dir Signed-off-by: michael sorens <[email protected]> * Minor cleanup Signed-off-by: michael sorens <[email protected]> * Apply review feedback Signed-off-by: michael sorens <[email protected]> * Regenerate v2-only pb files compile_all_protobuf_components Signed-off-by: michael sorens <[email protected]> * Regenerate docs from protos make sync_swagger_files Signed-off-by: michael sorens <[email protected]> * Empty commit to add missing DCO. Signed-off-by: michael sorens <[email protected]> Co-authored-by: michael sorens <[email protected]> Co-authored-by: Brenna Hewer-Darroch <[email protected]> Co-authored-by: M Sorens <[email protected]> Co-authored-by: Blake Johnson <[email protected]> Co-authored-by: susan evans <[email protected]> Co-authored-by: mjingle <[email protected]> Co-authored-by: Kimberly Garmoe <[email protected]>

msorens added 6 commits March 4, 2020 07:58

Relocate introspection protos to v2

5d0099b

Signed-off-by: michael sorens <[email protected]>

Rewire proto files together

ac87eae

Signed-off-by: michael sorens <[email protected]>

Change exposed endpoints to v2

c6d8797

Signed-off-by: michael sorens <[email protected]>

Regenerate from protos

746b90f

Signed-off-by: michael sorens <[email protected]>

Relocate introspection endpoints to v2

f7a2b8d

Signed-off-by: michael sorens <[email protected]>

Rewire go files together

87bcb8b

Signed-off-by: michael sorens <[email protected]>

msorens self-assigned this Mar 4, 2020

msorens commented Mar 4, 2020

View reviewed changes

msorens added auth-team anything that needs to be on the auth team board automate-auth labels Mar 4, 2020

msorens commented Mar 4, 2020

View reviewed changes

msorens added 4 commits March 4, 2020 15:17

Change UI calls to v2

1ce60fc

Signed-off-by: michael sorens <[email protected]>

Convert v1 integration test to v2

b081ce4

Signed-off-by: michael sorens <[email protected]>

msorens force-pushed the automate-2950/port-introspection branch from 4722686 to 5747a0b Compare March 4, 2020 23:17

msorens added this to the Auth: Sprint 9 milestone Mar 4, 2020

msorens requested a review from a team March 4, 2020 23:43

msorens marked this pull request as ready for review March 4, 2020 23:44

msorens requested a review from a team as a code owner March 4, 2020 23:44

msorens removed the request for review from a team March 4, 2020 23:52

blakestier reviewed Mar 5, 2020

View reviewed changes

components/automate-gateway/handler/iam/v2/introspect/introspect_test.go Outdated Show resolved Hide resolved

bcmdarroch reviewed Mar 5, 2020

View reviewed changes

components/automate-gateway/api/api_test.go Show resolved Hide resolved

bcmdarroch reviewed Mar 5, 2020

View reviewed changes

components/automate-gateway/gateway/services.go Outdated Show resolved Hide resolved

blakestier reviewed Mar 5, 2020

View reviewed changes

inspec/a2-iam-v2-integration/controls/introspection.rb Outdated Show resolved Hide resolved

blakestier approved these changes Mar 5, 2020

View reviewed changes

bcmdarroch reviewed Mar 5, 2020

View reviewed changes

bcmdarroch approved these changes Mar 5, 2020

View reviewed changes

Delete v1 auth URL in UI

7e5def5

Signed-off-by: michael sorens <[email protected]>

susanev added the v2 force upgrade branch label Mar 5, 2020

msorens added 2 commits March 5, 2020 14:40

Replace auth_v2_url with iam_url in UI

67bec08

Signed-off-by: michael sorens <[email protected]>

Apply assorted review feedback

f3c3959

Signed-off-by: michael sorens <[email protected]>

msorens force-pushed the automate-2950/port-introspection branch from 19b8f3e to f3c3959 Compare March 5, 2020 22:43

msorens merged commit 7e5bd56 into force-upgrade Mar 5, 2020

msorens deleted the automate-2950/port-introspection branch March 5, 2020 22:58

This was referenced Mar 6, 2020

[Automate-2950] port introspection, wave two #3050

Merged

Remove v1 handlers from gateway's authz.go #2808

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Automate-2950] Port introspection from v1 to v2 #3032

[Automate-2950] Port introspection from v1 to v2 #3032

msorens commented Mar 4, 2020 •

edited

Loading

msorens Mar 4, 2020

msorens Mar 4, 2020

msorens Mar 4, 2020

msorens Mar 4, 2020

msorens Mar 4, 2020

msorens Mar 4, 2020

blakestier Mar 5, 2020

bcmdarroch Mar 5, 2020

msorens Mar 5, 2020

msorens Mar 4, 2020

msorens Mar 4, 2020

msorens Mar 4, 2020

blakestier left a comment

bcmdarroch Mar 5, 2020

msorens Mar 5, 2020

bcmdarroch left a comment

		@@ -10,7 +10,6 @@ import (
		client_type "github.com/chef/automate/components/automate-cli/pkg/client"

[Automate-2950] Port introspection from v1 to v2 #3032

[Automate-2950] Port introspection from v1 to v2 #3032

Conversation

msorens commented Mar 4, 2020 • edited Loading

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blakestier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcmdarroch left a comment

Choose a reason for hiding this comment

msorens commented Mar 4, 2020 •

edited

Loading