remove v1 team APIs from gateway & update dependent integration tests #2952

bcmdarroch · 2020-02-24T18:28:00Z

🔩 Description: What code changed, and why?

Removes the /api/v0/auth/teams API and replaces any uses with the new and improved v2 API

👍 Definition of Done

no more /api/v0/auth/teams

👟 How to Build and Test the Change

rebuild components/automate-gateway && rebuild components/automate-cli

✅ Checklist

I have read the CONTRIBUTING document.
Tests added/updated?
Docs added/updated?
All commits have been signed-off for the Developer Certification of Origin.

msorens

Looking great! Just a few minor cleanup comments.

msorens · 2020-02-26T16:58:21Z

components/automate-cli/pkg/adminmgmt/adminmgmt.go

 	users_req "github.com/chef/automate/components/automate-gateway/api/auth/users/request"
 	"github.com/chef/automate/components/automate-gateway/api/authz"
 	authz_req "github.com/chef/automate/components/automate-gateway/api/authz/request"
+	v2 "github.com/chef/automate/components/automate-gateway/api/iam/v2"


Per earlier team discussion, prefer not to introduce references to "v2". Rather, should be the opposite: any references to "v2" should be eliminated where possible. Looks like you have mostly adhered to that, so I am just pointing out a few places where it could also be applied.

Suggested change

v2 "github.com/chef/automate/components/automate-gateway/api/iam/v2"

teams "github.com/chef/automate/components/automate-gateway/api/iam/v2"

msorens · 2020-02-26T17:00:50Z

components/automate-cli/pkg/client/mock/mock.go

@@ -60,9 +57,6 @@ func CreateMockConn(t *testing.T) (client.APIClient, ServerMocks, error) {
 	mockPolicies := v2.NewPoliciesServerMock()
 	v2.RegisterPoliciesServer(grpcGateway, mockPolicies)

-	mockTeams := teams.NewTeamsServerMock()
-	teams.RegisterTeamsServer(grpcGateway, mockTeams)
-
 	mockV2Teams := v2.NewTeamsServerMock()


Similar to above, better to rename this to mockTeams.

msorens · 2020-02-26T17:13:32Z

components/automate-gateway/gateway/services.go

-	pb_teams.RegisterTeamsServer(grpcServer, handler.NewTeamsServer(teamsV1Client))
-
-	teamsV2Client, err := clients.TeamsV2Client()
+	teamsV2Client, err := clients.TeamsClient()


s/teamsV2Client/teamsClient/

msorens · 2020-02-26T17:13:51Z

components/automate-gateway/gateway/services.go

@@ -365,7 +358,7 @@ func unversionedRESTMux(grpcURI string, dopts []grpc.DialOption) (http.Handler,
 		"cc_jobs":              pb_cc_jobs.RegisterJobsServiceHandlerFromEndpoint,
 		"nodes":                pb_nodes.RegisterNodesServiceHandlerFromEndpoint,
 		"profiles":             pb_profiles.RegisterProfilesServiceHandlerFromEndpoint,
-		"teams-service":        pb_teams.RegisterTeamsHandlerFromEndpoint,
+		"teams-service":        pb_iam_v2.RegisterTeamsHandlerFromEndpoint,


s/pb_iam_v2/pb_teams/

msorens · 2020-02-26T17:14:27Z

components/automate-grpc/protoc-gen-policy/README.md

+      additional_bindings {
+        post: "/iam/v2beta/teams"
+        body: "*"
+      }


msorens · 2020-02-26T17:17:10Z

e2e/cypress/integration/ui/settings/team_add_users.spec.ts

+  const userDisplayName = `${cypressPrefix} user ${now}`;
+  const username = `${cypressPrefix}-testing-user-${now}`;
+  const teamName = 'testing team';
+  const teamID = `${cypressPrefix}-testing-team-${now}`;


msorens · 2020-02-26T17:20:01Z

e2e/cypress/integration/ui/settings/team_mgmt.spec.ts

-      cy.cleanupTeamsByDescriptionPrefix(cypressPrefix);
+
+      // extra precaution in case the `after` cleanup didn't run due to a failure
+      cy.cleanupV2IAMObjectsByIDPrefixes(cypressPrefix, ['teams', 'projects', 'policies']);


msorens · 2020-02-26T17:21:43Z

inspec/a2-api-smoke/controls/base.rb

-    response_match: {
-      name: 'teams-service'
-    },
+    path: '/apis/iam/v2/teams',


Maybe mark this as a "todo"; my PR re-introduces the version endpoint for teams v2, so then this original test would work.

which PR is that? could you let me know if it merges before this one?

issue #2928

Yours is ready to merge, right? Mine is still in the works.

blakestier · 2020-03-03T22:00:49Z

components/automate-cli/pkg/adminmgmt/adminmgmt.go

-			Name: name,
+			Id:       id,
+			Name:     name,
+			Projects: []string{},


Why was this projects necessary? I would have expected it to be fine omitted

it's ok to omit it from the HTTP request, it gets marshalled to Projects: []string{} at the grpc level. Since we're using the grpc API directly here we have to specify the empty array.

(seems like we should be handling that at every level, though)

tylercloke · 2020-03-03T22:37:58Z

components/automate-gateway/api/api_test.go

-	_ "github.com/chef/automate/api/external/compliance/profiles"
-	_ "github.com/chef/automate/api/external/compliance/reporting"
-	_ "github.com/chef/automate/api/external/compliance/reporting/stats"
-	_ "github.com/chef/automate/api/external/compliance/scanner/jobs"


Interesting diff. Were none of these being used?

ooo good catch i think that was some overzealous rebase deletion

blakestier · 2020-03-04T21:36:11Z

components/automate-gateway/gateway/clients.go

@@ -287,24 +285,14 @@ func (c *clientsFactory) ProjectsClient() (iam_v2.ProjectsClient, error) {
 	return iam_v2.NewProjectsClient(conn), nil
 }

-// TeamsV1Client returns a V1 client for the Teams service.
+// TeamsClient returns a client for the Teams Mgmt service.


We have a teams mgmt service?

blakestier · 2020-03-04T21:39:44Z

e2e/cypress/integration/ui/settings/team_add_users.spec.ts

-      .should('have.attr', 'target', '_blank')
-      .should('have.attr', 'href', '/settings/users');
+      .contains('All local users have already been added; create some more!');
+    cy.get('chef-button').contains('Create User');


Woof nice work on this file 😅

time to see what breaks on bk... Signed-off-by: Brenna Hewer-Darroch <[email protected]>

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

the CLI and gateway no longer need to differentiate btwn versions of the teams client in an upcoming PR, we'll remove the v1 teams client altogether Signed-off-by: Brenna Hewer-Darroch <[email protected]>

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

decided to remove the teams version endpoint for now all we really care about in this test is that GET /teams API responds with 200 we can discuss as a team if we think a version endpoint should be added back in Signed-off-by: Brenna Hewer-Darroch <[email protected]>

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

mostly needed to swap description for name in API requests Signed-off-by: Brenna Hewer-Darroch <[email protected]>

mostly fixing v2 references Signed-off-by: Brenna Hewer-Darroch <[email protected]>

also add back some imports Signed-off-by: Brenna Hewer-Darroch <[email protected]>

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

* Remove IAM V1 conditionals from the UI and Cypress (#2753) * UI unit test cleanup post-merge of master Signed-off-by: michael sorens <[email protected]> * UI unit test cleanup post-merge of master Signed-off-by: michael sorens <[email protected]> * [Automate-1890] gateway v1 scrub (#2796) * [automate-2857] Update user service to teams v2 client (#2860) * Add method for proto parity Adding PurgeUserMembership to allow replacing the v1 team client with a v2 version. Signed-off-by: michael sorens <[email protected]> * Switch v1 team client to v2 team client Signed-off-by: michael sorens <[email protected]> * Implement necessary method for the revised interface Signed-off-by: michael sorens <[email protected]> * Update bldr.toml Removed dependency required rerunning `generate_bldr_config` Signed-off-by: michael sorens <[email protected]> * Correct admins team name per feedback Signed-off-by: michael sorens <[email protected]> * [automate-2720] IAM force upgrade migrations 🎉 (#2793) * Added general structure and TODOs for how to migrate up to the point of force upgrade Copied over code from migrator.go because we can't use the generic version anymore. Migrating up to the last SQL schema migration before we want to force upgrade. Started porting MigrateToV2 GRPC function over to the migration code. Signed-off-by: Tyler Cloke <[email protected]> * Remove ApplyV2DataMigrations db function and finish applying any data_migrations as part of the post-force-upgrade process Signed-off-by: Tyler Cloke <[email protected]> * Ported creation of default roles for v1 force upgrade Signed-off-by: Tyler Cloke <[email protected]> * Port defaultPolicies Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Port CreatePolicy Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Port code we might need for legacy migration Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * WIP Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Everything is compiling Signed-off-by: Tyler Cloke <[email protected]> * Added force_upgrade_status to only run force upgrade once Signed-off-by: Tyler Cloke <[email protected]> * Remove UpgradeToV2 from cli/gateway Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove auto-upgrade from studio Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Record migration status for versioning Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Rename constant Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove unused migration Signed-off-by: Tyler Cloke <[email protected]> * Use migration status to control migration logic Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Do TODOs Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove migration-related server code Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Updated our use of migration_status and cleaned up file layout Signed-off-by: Tyler Cloke <[email protected]> * Fixed variable name Signed-off-by: Tyler Cloke <[email protected]> * It working Signed-off-by: Tyler Cloke <[email protected]> * Initial porting work for tests Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Working on db tests Signed-off-by: Tyler Cloke <[email protected]> * It's passsssing Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Legacy Policy test Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Does not migrate legacy pols w/o subjs Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Legacy policies Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Migrates only valid v1 policies Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Simply log unmigrated policies These were already invalid in v1. No big deal if they aren't migrated. Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Add comment Signed-off-by: Tyler Cloke <[email protected]> * Renames/cleanup Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Remove ResetToV1 from gateway Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Updates bldr.toml Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Compilation errors from server change Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * remove resettov1 Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Fix :allthethings: Signed-off-by: Tyler Cloke <[email protected]> * Linting Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Trying to get CI happy Signed-off-by: Tyler Cloke <[email protected]> * Remove upgrade-to-v2 cmd Signed-off-by: Tyler Cloke <[email protected]> * Remove upgrade-to-v2 Signed-off-by: Tyler Cloke <[email protected]> * No longer have PreconditionFailed to tell v1 requests the gateway is in v2 mode. Just always use v2. Signed-off-by: Tyler Cloke <[email protected]> * Hopefully tests pass now Signed-off-by: Tyler Cloke <[email protected]> * Bldr config Signed-off-by: Tyler Cloke <[email protected]> * Add deny for infra:ingest:* to default policy migration Signed-off-by: Tyler Cloke <[email protected]> * Delete extra comment Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * add clarity to func Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Only migrate v1 policies on upgrade Signed-off-by: Blake Johnson <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Review comments Signed-off-by: Tyler Cloke <[email protected]> * Update components/authz-service/storage/postgres/postgres.go Co-Authored-By: M Sorens <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Update components/authz-service/storage/postgres/migration/migration.go Co-Authored-By: M Sorens <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Update components/authz-service/storage/postgres/migration/migration.go Co-Authored-By: M Sorens <[email protected]> Signed-off-by: Tyler Cloke <[email protected]> * Last review comments Signed-off-by: Tyler Cloke <[email protected]> Co-authored-by: Tyler Cloke <[email protected]> Co-authored-by: M Sorens <[email protected]> * [automate-2930] Fix NATS gateway test errors related to v2 force upgrade (#2933) * Add some logging around forced migration (#2938) * [automate-2861] Update authn service to teams v2 client (#2875) * [automate-2876] Update automate-deployment to teams v2 client (#2877) * Change IAM docs to focus on IAM v2 (#2715) * combine iamv1 pages into 1 Signed-off-by: susanev <[email protected]> * change users, teams, api tokens to iam v2 Signed-off-by: susanev <[email protected]> * added pages for policies, projects, roles Signed-off-by: susanev <[email protected]> * Copyedits and edits for clarity Signed-off-by: Mary Jinglewski <[email protected]> Co-authored-by: mjingle <[email protected]> Co-authored-by: susanev <[email protected]> * Auth 2926/teams v2 migrations (#2934) * Move operator team rename into schema migs Signed-off-by: Blake Johnson <[email protected]> * Integrate cli migration into schema migration Signed-off-by: Blake Johnson <[email protected]> * Remove datamigrations Signed-off-by: Blake Johnson <[email protected]> * Rename migration Signed-off-by: Blake Johnson <[email protected]> * Remove refs to datamigration Signed-off-by: Blake Johnson <[email protected]> * Remove refs to upgrade/reset iam * Cleanup after merge-from-master * Regenerate from protos after merge-from-master compile_go_protobuf_component automate-gateway && compile_go_protobuf_component api Signed-off-by: michael sorens <[email protected]> * Auth 2867/remove v1 tokens gateway apis (#2970) * remove tokens (v1) proto Signed-off-by: Blake Johnson <[email protected]> * Remove v1 tokens client Signed-off-by: Blake Johnson <[email protected]> * Modify UI to only use tokens v2 path Signed-off-by: Blake Johnson <[email protected]> * Update docs Signed-off-by: Blake Johnson <[email protected]> * Bright more files up to v2 for tokens Signed-off-by: Blake Johnson <[email protected]> * Update dev helper Signed-off-by: Blake Johnson <[email protected]> * Update docs Signed-off-by: Blake Johnson <[email protected]> * Remove v1 handler Signed-off-by: Blake Johnson <[email protected]> * Update bldr config Signed-off-by: Blake Johnson <[email protected]> * Remove v1 mock Signed-off-by: Blake Johnson <[email protected]> * remove v2 allusions Signed-off-by: Blake Johnson <[email protected]> * Revert docs change Signed-off-by: Blake Johnson <[email protected]> * [AUTOMATE-2866] Remove v1 users APIs from gateway (#2922) Signed-off-by: Tyler Cloke <[email protected]> * Fix force-upgrade merge conflicts (#2981) * Regenerate from protos after merge hab studio: compile_all_protobuf_components components/automate-chef-io: make sync_swagger_files Signed-off-by: michael sorens <[email protected]> * [automate-2868] Remove v1 policies (#2988) * [Automate-2950] Port introspection from v1 to v2 (#3032) * Relocate introspection protos to v2 Signed-off-by: michael sorens <[email protected]> * Rewire proto files together Signed-off-by: michael sorens <[email protected]> * Change exposed endpoints to v2 Signed-off-by: michael sorens <[email protected]> * Regenerate from protos Signed-off-by: michael sorens <[email protected]> * Relocate introspection endpoints to v2 Signed-off-by: michael sorens <[email protected]> * Rewire go files together Signed-off-by: michael sorens <[email protected]> * Change UI calls to v2 Signed-off-by: michael sorens <[email protected]> * Convert v1 integration test to v2 Signed-off-by: michael sorens <[email protected]> * Resolve path changes in cli component Starting with ` rebuild components/automate-cli/`, the error was: build github.com/chef/automate/components/automate-gateway/api/authz: cannot load github.com/chef/automate/components/automate-gateway/api/authz: no Go source files Traced that back to the same failure with just `make build` in the automate-cli directory, then to the same failure with just this: go build github.com/chef/automate/components/automate-cli/cmd/chef-automate Searching for api/authz in the cli directory led me to the files in this commit. Signed-off-by: michael sorens <[email protected]> * Regenerate bldr.toml The "repo health" task in buildkite failed saying: ``` The bldr config appears to be out of date! To fix this, run: hab studio run "source .studiorc && generate_bldr_config" ``` Ran the fix: # install_if_missing core/go go # generate_bldr_config Signed-off-by: michael sorens <[email protected]> * Delete v1 auth URL in UI Signed-off-by: michael sorens <[email protected]> * Replace auth_v2_url with iam_url in UI Signed-off-by: michael sorens <[email protected]> * Apply assorted review feedback Signed-off-by: michael sorens <[email protected]> * remove v1 team APIs from gateway & update dependent integration tests (#2952) * gateway: delete v1 team protos * gateway: drop v1 team stuff wherever it's imported * cli: use v2 teams client everywhere Signed-off-by: Brenna Hewer-Darroch <[email protected]> * [automate-2914] force-upgrade integration scenario: v1 -> v2 with migrated legacy policies (#2935) * v1 to force-upgrade v2 integration test reorganized all the IAM inspec tests Signed-off-by: Brenna Hewer-Darroch <[email protected]> Co-authored-by: Blake Johnson <[email protected]> Co-authored-by: M Sorens <[email protected]> * [Automate-2987] legacy ingest policy fix (#3044) * migration: any "{infra:ingest:*}" action is now "{ingest:*}" * update force-upgrade delete the "deny users infra:ingest" statement in infra legacy policy swap "infra:ingest:*" for "ingest:*" in ingest legacy policy * legacy policy migration testing Co-authored-by: Blake Johnson <[email protected]> Co-authored-by: Brenna Hewer-Darroch <[email protected]> * Resync bldr.toml generate_bldr_config Signed-off-by: michael sorens <[email protected]> * [automate-2916] v2 with no legacy policies -> force-upgrade to latest v2 integration test (#3009) * add v2 with no legacy force-upgrade to v2 we want to make sure that customers currently using v2 without v1 legacy policies are not disrupted by the force-upgrade. v1 legacy policies should not reappear. Signed-off-by: Brenna Hewer-Darroch <[email protected]> * [automate-2917] v2 with legacy policies -> force-upgrade to latest v2 integration test (#3008) * add force-upgrade v2 from v2 with legacy integration test we want to ensure that customers currently using IAM v2 are not disrupted by the force-upgrade Signed-off-by: Brenna Hewer-Darroch <[email protected]> * Vanished teams on force-upgrade (#3102) * Robust Deprecation of IAM v1 (#3104) * Robust Deprecation of v1 Signed-off-by: kagarmoe <[email protected]> * Deprecation on nav * Deprecation on nav Signed-off-by: kagarmoe <[email protected]> * Incorporates feedback Signed-off-by: kagarmoe <[email protected]> * Use feature branch iam-v2-overview.md Signed-off-by: kagarmoe <[email protected]> * Improve verb tense in IAM v2 Overview doc (#3033) * Improve verb tense in IAM v2 Overview doc Signed-off-by: Mary Jinglewski <[email protected]> * Edit progress so far Signed-off-by: Mary Jinglewski <[email protected]> * Incorporate Feedback Signed-off-by: Mary Jinglewski <[email protected]> * Active tense polishing Signed-off-by: Mary Jinglewski <[email protected]> * removes iam v2 from body Signed-off-by: kagarmoe <[email protected]> * Fix spaces Signed-off-by: kagarmoe <[email protected]> Co-authored-by: kagarmoe <[email protected]> * Revert "Improve verb tense in IAM v2 Overview doc (#3033)" (#3134) This reverts commit 746d6ea. * [automate-3065] Remove v1 authz storage (#3111) * fixes bad link Signed-off-by: kagarmoe <[email protected]> * Fix iam db migration tests to work locally (#3155) Signed-off-by: Tyler Cloke <[email protected]> * Revert "Revert "Improve verb tense in IAM v2 Overview doc (#303… (#3145) * Merge fix Signed-off-by: michael sorens <[email protected]> * [automate-3066] Delete authz v1 server code (#3146) * [automate-1886] farewell chef-automate admin-token (#3188) * chef-automate admin-token is no more Co-authored-by: Brenna Hewer-Darroch <[email protected]> Co-authored-by: Mary Jinglewski <[email protected]> * [automate-2710] Remove system:* perms, modify infra:* perms (#3148) * Update roles to have infra:nodes/nodeManagers over infra:* Signed-off-by: Blake Johnson <[email protected]> * Update roles to not have system access Signed-off-by: Blake Johnson <[email protected]> * Update docs with system change Signed-off-by: Blake Johnson <[email protected]> * update sql readme Signed-off-by: Blake Johnson <[email protected]> * Refactor query to work w/o policy Signed-off-by: Blake Johnson <[email protected]> * Add telemetry perms into default system policies Signed-off-by: Blake Johnson <[email protected]> * Update tests Signed-off-by: Blake Johnson <[email protected]> * Remove non-existent action for telemetry Signed-off-by: Blake Johnson <[email protected]> * remove (in tests) permission to request license to roles Signed-off-by: Blake Johnson <[email protected]> * Modify integration script Signed-off-by: Blake Johnson <[email protected]> * Add comments Signed-off-by: Blake Johnson <[email protected]> * Adds applications to roles Signed-off-by: Blake Johnson <[email protected]> * [Automate-2950] port introspection, wave two (#3050) * Update proto generation for v2-only Signed-off-by: michael sorens <[email protected]> * Remove v2 distinction in the generated code Signed-off-by: michael sorens <[email protected]> * Remove v1 protoc generation Signed-off-by: michael sorens <[email protected]> * Remove v2 from the generated pb file name Signed-off-by: michael sorens <[email protected]> * Correct path * Manual cleanup to get things building Not sure why these were not covered by the regeneration but was getting this error until I found and removed these: $ make build build github.com/chef/automate/components/automate-gateway/cmd/automate-gateway: cannot load github.com/chef/automate/components/automate-gateway/authz/policy_v2: open /Users/msorens/code/go/src/github.com/chef/automate/components/automate-gateway/authz/policy_v2: no such file or directory Signed-off-by: michael sorens <[email protected]> * Regenerate bldr.toml Signed-off-by: michael sorens <[email protected]> * Relocate pairs and policy under iam dir Signed-off-by: michael sorens <[email protected]> * Minor cleanup Signed-off-by: michael sorens <[email protected]> * Apply review feedback Signed-off-by: michael sorens <[email protected]> * Regenerate v2-only pb files compile_all_protobuf_components Signed-off-by: michael sorens <[email protected]> * Regenerate docs from protos make sync_swagger_files Signed-off-by: michael sorens <[email protected]> * Empty commit to add missing DCO. Signed-off-by: michael sorens <[email protected]> Co-authored-by: michael sorens <[email protected]> Co-authored-by: Brenna Hewer-Darroch <[email protected]> Co-authored-by: M Sorens <[email protected]> Co-authored-by: Blake Johnson <[email protected]> Co-authored-by: susan evans <[email protected]> Co-authored-by: mjingle <[email protected]> Co-authored-by: Kimberly Garmoe <[email protected]>

bcmdarroch added automate-auth automate-gateway auth-team anything that needs to be on the auth team board v2 force upgrade branch labels Feb 24, 2020

bcmdarroch requested a review from a team February 24, 2020 18:28

bcmdarroch requested a review from a team as a code owner February 24, 2020 18:28

bcmdarroch self-assigned this Feb 24, 2020

bcmdarroch force-pushed the bhd/2724/remove-v1-team-apis branch 2 times, most recently from 9bcab71 to 88bc17b Compare February 26, 2020 00:23

msorens approved these changes Feb 26, 2020

View reviewed changes

bcmdarroch force-pushed the bhd/2724/remove-v1-team-apis branch 2 times, most recently from 6e51509 to 2f96dac Compare March 3, 2020 18:14

blakestier reviewed Mar 3, 2020

View reviewed changes

tylercloke approved these changes Mar 3, 2020

View reviewed changes

bcmdarroch force-pushed the bhd/2724/remove-v1-team-apis branch 2 times, most recently from ecc5300 to a94a47f Compare March 4, 2020 18:18

blakestier reviewed Mar 4, 2020

View reviewed changes

blakestier approved these changes Mar 4, 2020

View reviewed changes

bcmdarroch force-pushed the bhd/2724/remove-v1-team-apis branch from a94a47f to 51905ea Compare March 5, 2020 18:27

Brenna Hewer-Darroch added 10 commits March 5, 2020 15:26

gateway: delete v1 team protos

368b2cb

time to see what breaks on bk... Signed-off-by: Brenna Hewer-Darroch <[email protected]>

gateway: drop v1 team stuff wherever it's imported

c8bf1d8

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

cli: use v2 teams client everywhere

38e74a9

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

cli/gateway: rename teamsV2 to just teams

95a02b5

the CLI and gateway no longer need to differentiate btwn versions of the teams client in an upcoming PR, we'll remove the v1 teams client altogether Signed-off-by: Brenna Hewer-Darroch <[email protected]>

misc: update auth/teams -> iam/v2/teams paths

e4f44b1

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

inspec: fix authz_access_control

f17fccb

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

ui: update auth/teams -> iam/v2/teams

d5b57e0

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

cypress: fix cypress tests

228407f

mostly needed to swap description for name in API requests Signed-off-by: Brenna Hewer-Darroch <[email protected]>

address review

ce8b5ae

mostly fixing v2 references Signed-off-by: Brenna Hewer-Darroch <[email protected]>

Brenna Hewer-Darroch added 2 commits March 5, 2020 15:29

fix adminmgmt_test post-rebase

451c30d

also add back some imports Signed-off-by: Brenna Hewer-Darroch <[email protected]>

fix gateway build

8c1fae8

Signed-off-by: Brenna Hewer-Darroch <[email protected]>

bcmdarroch force-pushed the bhd/2724/remove-v1-team-apis branch from 51905ea to 8c1fae8 Compare March 5, 2020 23:30

bcmdarroch merged commit 0faec97 into force-upgrade Mar 5, 2020

snyk-bot mentioned this pull request Jun 30, 2021

[Snyk] Security upgrade prismjs from 1.21.0 to 1.24.0 PratyakshaSinha/automate#41

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove v1 team APIs from gateway & update dependent integration tests #2952

remove v1 team APIs from gateway & update dependent integration tests #2952

bcmdarroch commented Feb 24, 2020 •

edited

Loading

msorens left a comment

msorens Feb 26, 2020

msorens Feb 26, 2020

msorens Feb 26, 2020

msorens Feb 26, 2020

msorens Feb 26, 2020

msorens Feb 26, 2020

msorens Feb 26, 2020

msorens Feb 26, 2020

bcmdarroch Feb 26, 2020

msorens Feb 26, 2020

msorens Feb 26, 2020

blakestier Mar 3, 2020

bcmdarroch Mar 3, 2020

blakestier Mar 4, 2020

tylercloke Mar 3, 2020

bcmdarroch Mar 3, 2020

blakestier Mar 4, 2020

blakestier Mar 4, 2020

	v2 "github.com/chef/automate/components/automate-gateway/api/iam/v2"
	teams "github.com/chef/automate/components/automate-gateway/api/iam/v2"

remove v1 team APIs from gateway & update dependent integration tests #2952

remove v1 team APIs from gateway & update dependent integration tests #2952

Conversation

bcmdarroch commented Feb 24, 2020 • edited Loading

🔩 Description: What code changed, and why?

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

msorens left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcmdarroch commented Feb 24, 2020 •

edited

Loading