Fix eslint errors #4485
Fix eslint errors #4485
Conversation
src/core/core.scale.js
Outdated
| min < 0 && max < 0? max : | ||
| min > 0 && max > 0? min : | ||
| 0; | ||
| return me.beginAtZero ? 0 : |
There was a problem hiding this comment.
Is this a new rule? I don't think it makes the code more readable, I would disable it
There was a problem hiding this comment.
I thought so at first too, but then I realized that it more clearly communicates that each line is a continuation of the past and each new line is an else statement of the previous.
In general, I think it's a good rule that continued lines should be indented from the previous. I'm not sure we'd want to disable that entirely because of just one place where we might not like the effect
test/specs/plugin.filler.tests.js
Outdated
| 7, // 5 + 2 | ||
| 5, // 6 - 1 | ||
| 'end', // 'end' | ||
| 'start', // 'origin' |
There was a problem hiding this comment.
Is there any reason to change spaces to tabs for comment alignment?
It breaks when changing editor config, for example (1 tab == 2 spaces):
There was a problem hiding this comment.
I was able to reconfigure the no-multi-spaces option to stop creating errors when it's a comment after a line and reverted the spacing changes
There was a problem hiding this comment.
Crap, this option broke Code Climate because it's only available in eslint v4 and Code Climate only supports eslint v3 :-( codeclimate/codeclimate-eslint#283
benmccann
force-pushed
the
gulp-eslint
branch
4 times, most recently
from
2580be7 to
db37286
Compare
|
I've reverted the actual eslint upgrade for now since codeclimate only supports eslint 3 at the moment. I'd still like to check in all the style fixes though so that when codeclimate adds eslint 4 support in the future it will be an easy upgrade |
| @@ -170,7 +170,7 @@ module.exports = function(Chart) { | |||
| // the canvas render width and height will be casted to integers so make sure that | |||
| // the canvas display style uses the same integer values to avoid blurring effect. | |||
|
|
|||
| // Set to 0 instead of canvas.size because the size defaults to 300x150 if the element is collased | |||
| // Set to 0 instead of canvas.size because the size defaults to 300x150 if the element is collased | |||
There was a problem hiding this comment.
That's weird ESLint didn't reported these spaces instead of tabs
Upgrades
gulp-eslintand fixes errors