Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ESLint 4.0.0 #283

Closed
kunagpal opened this issue Jun 12, 2017 · 13 comments
Closed

Support for ESLint 4.0.0 #283

kunagpal opened this issue Jun 12, 2017 · 13 comments
Assignees

Comments

@kunagpal
Copy link

No description provided.

@msteward
Copy link

msteward commented Jun 29, 2017

ESLint v4+ supports the eslintignore being inside the package.json file too so this might need a tweak to the init scripts to not create an eslintignore file by default?

@kunagpal
Copy link
Author

kunagpal commented Jul 1, 2017

@msteward http://eslint.org/docs/user-guide/migrating-to-4.0.0 doesn't suggest that .eslintignore files are deprecated. Since most people would prefer to keep their package.json files bloat free, an alternative course of action here could be to keep the init scripts as is, and ensure that the channel: eslint-4 branch on this repository respects the ignore config within packge.json (Although that is something that ESLint v4.x would handle anyway).

@kunagpal
Copy link
Author

kunagpal commented Jul 4, 2017

@chrishulton Is there an E.T.A on this?

@chrishulton
Copy link
Contributor

Hey @kunagpal, sorry I missed this issue. Supporting eslint 4 sounds worthwhile, but due to other priorities, we aren't working on it at this time. If we do begin work on this, we'll provide an update here with an ETA.

@benmccann
Copy link

I would really love to see this. I want to specify ignoreEOLComments in my .eslintrc file, but it looks to me like I can only set that option since ESLint v4.

@kunagpal
Copy link
Author

kunagpal commented Aug 2, 2017

This is now available via the eslint-4 channel, thanks! 👍

@kunagpal kunagpal closed this as completed Aug 2, 2017
@pointlessone
Copy link
Contributor

A bit premature celebration. It's about to be available, but not just yet.

@benmccann
Copy link

Yeah, I get Unable to find an image for eslint:eslint-4. Available channels: ["stable", "eslint-1", "eslint-2", "eslint-3"].

Would you be able to report back here when it's available?

@pointlessone
Copy link
Contributor

Sure.

@pointlessone pointlessone reopened this Aug 2, 2017
@kunagpal
Copy link
Author

@pointlessone Is the ESLint 4 channel available now?

@pointlessone
Copy link
Contributor

Yes, but CLI has not been updated yet. You may need manually install the engine. Also note, that you will need to make sure your ESLint config is compatible with v4. Auto upgradng is not supported yet.

@pointlessone
Copy link
Contributor

eslint-4 channel is available both on CC and in CLI.

@WesTyler
Copy link

Is the intention to bring the main module up to eslint 4 soon? Just curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants