-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use our shared prettier config #1524
Conversation
prettier-config-edu is not a prettier plugin, so passing it to `plugins` isn't doing anything. Instead, it's just an object that we can export (or spread) from our config.
Codecov Report
@@ Coverage Diff @@
## main #1524 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 284 284
Lines 4300 4300
Branches 793 793
=======================================
Hits 3955 3955
Misses 320 320
Partials 25 25 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
{ | ||
"trailingComma": "all", | ||
"singleQuote": true, | ||
"plugins": ["@chanzuckerberg/prettier-config-edu"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier-config-edu isn't a plugin, so adding it here wasn't actually using it.
Or at least wasn't using it for the rules config. But maybe was somehow configuring the Tailwind plugin 🤔 ?
size-limit report 📦
|
"trailingComma": "all", | ||
"singleQuote": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These overrides were the clue that our shared config wasn't being used, since the shared config has the same values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the end result was the same because the overrides, but now we're actually using the correct config?
That's right |
Summary:
Not sure if this was intended from #1457 or not, but it turns out we aren't actually using our shared prettier config. More deets inline.
This PR
Test Plan: