Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use czi/prettier-config-edu #1457

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Use czi/prettier-config-edu #1457

merged 4 commits into from
Jan 11, 2023

Conversation

jinlee93
Copy link
Contributor

Summary:

  • adds prettier config for Tailwind for linted classname orders
  • recommends TW vscode extension in docs
  • fixes lint issues from aforementioned prettier config

Test Plan:

  • no associated lint errors

@jinlee93 jinlee93 requested a review from a team January 11, 2023 00:13
@jinlee93 jinlee93 changed the title Add prettier config for Tailwind RFC: Add prettier config for Tailwind Jan 11, 2023
@jinlee93 jinlee93 added the RFC Proposal/Request for Comments label Jan 11, 2023
@jinlee93 jinlee93 changed the title RFC: Add prettier config for Tailwind Add prettier config for Tailwind Jan 11, 2023
@jinlee93
Copy link
Contributor Author

jinlee93 commented Jan 11, 2023 •
edited
Loading

Realized this was already part of czi/prettier-config-edu will just update to use that

booc0mtaco
booc0mtaco approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@booc0mtaco
Copy link
Contributor

@jinlee93 This will only affect usage in storybook, correct?

@jinlee93 jinlee93 changed the title Add prettier config for Tailwind Use czi/prettier-config-edu Jan 11, 2023
@jinlee93
Copy link
Contributor Author

@jinlee93 This will only affect usage in storybook, correct?

Since this is just adding prettier to lint for TW classname orders, it shouldn't affect anything, especially since TW classnames are only being used for stories or non component / release files.

@jinlee93 jinlee93 merged commit 3a3c713 into next Jan 11, 2023
@jinlee93 jinlee93 deleted the jlee/tailwindPrettier branch January 11, 2023 18:13
@ahuth ahuth mentioned this pull request Mar 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@booc0mtaco booc0mtaco booc0mtaco approved these changes

Assignees
No one assigned
Labels
RFC Proposal/Request for Comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee93 @booc0mtaco