Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt fix and enable for Ubuntu 22 #6975

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#-------------------------------------------------------------------------------------------------------
# Copyright (c) 2021 ChakraCore Project Contributors. All rights reserved.
# Copyright (c) ChakraCore Project Contributors. All rights reserved.
# Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
#-------------------------------------------------------------------------------------------------------

Expand Down Expand Up @@ -32,17 +32,32 @@ jobs:
strategy:
maxParallel: 6
matrix:
Linux.Debug:
image_name: 'ubuntu-22.04'
deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
build_type: 'Debug'
libtype_flag: ''
Linux.NoJit:
image_name: 'ubuntu-20.04'
image_name: 'ubuntu-22.04'
deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
build_type: 'Debug'
libtype_flag: '-DDISABLE_JIT=ON'
Linux.ReleaseWithDebug:
image_name: 'ubuntu-20.04'
image_name: 'ubuntu-22.04'
deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
build_type: 'RelWithDebInfo'
libtype_flag: ''
Linux.Release:
image_name: 'ubuntu-22.04'
deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
build_type: 'Release'
libtype_flag: ''
Ubuntu20.ReleaseWithDebug:
image_name: 'ubuntu-20.04'
deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
build_type: 'RelWithDebInfo'
libtype_flag: ''
Ubuntu20.Release:
image_name: 'ubuntu-20.04'
deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
build_type: 'Release'
Expand Down
8 changes: 1 addition & 7 deletions pal/inc/cclock.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,7 @@
#ifndef CC_PAL_INC_CCLOCK_H
#define CC_PAL_INC_CCLOCK_H

#if defined(_M_ARM64)
#define CCLOCK_ALIGN __declspec(align(8))
#else
#define CCLOCK_ALIGN
#endif

class CCLOCK_ALIGN CCLock
class __declspec(align(sizeof(size_t))) CCLock
{
char mutexPtr[64]; // keep mutex implementation opaque to consumer (PAL vs non-PAL)

Expand Down
6 changes: 3 additions & 3 deletions test/runtests.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env python
#-------------------------------------------------------------------------------------------------------
# Copyright (C) Microsoft. All rights reserved.
# Copyright (c) 2021 ChakraCore Project Contributors. All rights reserved.
# Copyright (c) ChakraCore Project Contributors. All rights reserved.
# Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
#-------------------------------------------------------------------------------------------------------

Expand Down Expand Up @@ -316,11 +316,11 @@ def __init__(self, name, compile_flags=[], variant_not_tags=[]):

@staticmethod
def _has_expansion(flags):
return any(re.match('.*\${.*}', f) for f in flags)
return any(re.match(r'.*\${.*}', f) for f in flags)

@staticmethod
def _expand(flag, test):
return re.sub('\${id}', str(test.id), flag)
return re.sub(r'\${id}', str(test.id), flag)

def _expand_compile_flags(self, test):
if self._compile_flags_has_expansion:
Expand Down
Loading