Attempt fix and enable for Ubuntu 22 #6975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2024
|
I've played around with this, not sure if there is just one place where the alignment is needed, but hopefully we can figure this out. |
|
@rhuanjl I've added @ShortDevelopment's fix to the PR, but since it is your branch, feel free to remove/rework/change in anyway you want. |
ppenzin
approved these changes
Apr 17, 2024
|
And I had to remove that fix, the issue is that MSVC doesn't like noinline attribute, so it has to be an ifdef or something like that - we can revisit. The code would work on Ubuntu and not necessary on Windows. |
Merged
|
I've updated the workaround to hopefully work on MSVC, trying it out in #6977, though not sure it is the optimal solution in the long run. |
|
Planning to merge #6932 then we can follow up with a working version of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from #6932 + enable CI for Ubuntu 22