-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox Sidemenu Updated, Checkbox States (Error/Warning/Success) #287
Conversation
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Changes: - Checkbox - Includes Status Styling (Error/Warning/Success)
…box-radiobuttons-sidemenu-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shindigira
This is looking great! I have a few structural changes and then we should be good to go.
As we discussed I'd like to group this component as follows:
Sidebar menu:
- Checkboxes
- Checkbox
- Overview
- Enabled
- Hover
- Focus
- Selected
- Disabled
- Disabled/selected
- Success
- Warning
- Error
- With helper text
- Large target area
- Overview
- Enabled
- Hover
- Focus
- Selected
- Disabled
- Disabled/selected
- With helper text
- Checkbox
Additional changes:
- Change "Default" to "Enabled" for the base state
- In helper text examples change the label text to "Label"
Updated. Please review and provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shindigira
Nice work! Just a few details and we should be good to go:
- Change "Default" to "Checkbox"
- Is it possible for the page to read "Large target area checkbox" and still have the side menu read "Large target area"? This would match the DS.
I changed the 'Default' to For the last part, it seems Storybook links the two. I'd have to dig-in and see if there is a workaround. |
@natalia-fitzgerald As discussed, we decided not to pursue this at the moment. |
@meissadia When reviewing, will need special attention to this autodocs change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shindigira - Great work! This looks good and move to verified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job finding ways to reconfigure in order to achieve the custom Overviews!
e522706
…box-radiobuttons-sidemenu-update
Closes #286
Closes #285
Changes
Screenshots (Updated 01/28/2024)
Sidemenu Updated
New Checkbox Status