Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox][Table of Contents] Storybook Sidemenu Update #286

Closed
shindigira opened this issue Jan 23, 2024 · 1 comment · Fixed by #287
Closed

[Checkbox][Table of Contents] Storybook Sidemenu Update #286

shindigira opened this issue Jan 23, 2024 · 1 comment · Fixed by #287
Assignees
@shindigira
Labels
enhancement New feature or request

Comments

@shindigira
Copy link
Contributor

shindigira commented Jan 23, 2024 •
edited
Loading

Update Checkbox Storybook tree menu to this format:

Screenshot 2024-01-25 at 11 24 43 PM
@shindigira shindigira added the enhancement New feature or request label Jan 23, 2024
@shindigira shindigira self-assigned this Jan 23, 2024
@shindigira shindigira mentioned this issue Jan 23, 2024
Merged
@natalia-fitzgerald
Copy link

natalia-fitzgerald commented Jan 24, 2024 •
edited
Loading

@shindigira
This is looking great! I have a few structural changes and then we should be good to go.

As we discussed I'd like to group this component as follows:

Sidebar menu:

  • Checkboxes
    • Checkbox
      • Overview
      • Enabled
      • Hover
      • Focus
      • Selected
      • Disabled
      • Disabled/selected
      • Success
      • Warning
      • Error
      • With helper text
    • Large target area
      • Overview
      • Enabled
      • Hover
      • Focus
      • Selected
      • Disabled
      • Disabled/selected
      • With helper text

Additional changes:


  • Change "Default" to "Enabled" for the base state
  • In helper text examples change the label text to "Label"
  • Make status states interactive on the page

@shindigira shindigira changed the title Checkbox - Storybook Sidemenu Update [Checkbox][Table of Contents] Storybook Sidemenu Update Jan 29, 2024
shindigira added a commit that referenced this issue Jan 30, 2024
@shindigira
Checkbox Sidemenu Updated, Checkbox States (Error/Warning/Success) (#287
307f291 
)

Closes #286 
Closes #285 

## Changes
- Checkbox - Storybook Sidemenu Update
- Styling: Checkbox States (Error/Warning/Success) 

## Screenshots (Updated 01/28/2024)
### Sidemenu Updated

|Before|After|
|---|---|
|<img width="195" alt="Screenshot 2024-01-23 at 12 52 25 PM"
src="https://github.com/cfpb/design-system-react/assets/13324863/10c24c26-e95d-4797-9f40-df693748a071">|<img
width="1097" alt="Screenshot 2024-01-29 at 11 21 59 AM"
src="https://github.com/cfpb/design-system-react/assets/13324863/09a78a6d-20cd-4cd8-a822-4d7a63fed95c">|

### New Checkbox Status
<img width="148" alt="Screenshot 2024-01-23 at 12 54 16 PM"
src="https://github.com/cfpb/design-system-react/assets/13324863/51ccbe5d-a264-4bac-afe9-da2ff5f2be78">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shindigira shindigira

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checkbox Sidemenu Updated, Checkbox States (Error/Warning/Success) cfpb/design-system-react
2 participants
@shindigira @natalia-fitzgerald