refactor: scrap HomeDB for generalized OpticsDB #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketchang
added
rust 🦀
luketchang
force-pushed
the
luke/db-refactor
branch
from
d68b084 to
f849e1d
Compare
luketchang
changed the title
emberian
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we move to storing replica chain state as well, the concept of
HomeDBthat containshome_namejust isn't as useful anymore. This PR replaces it with more generalOpticsDBwhich will store any on-chain data for a home or a replica. The main difference is that every load/store is associated with an entity name (home or replica name).Closes #900
For #899