refactor: separate db from home and consolidate home_db and syncing #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketchang
added
rust 🦀
luketchang
commented
Oct 7, 2021
| @@ -1,7 +1,7 @@ | |||
| //! Interfaces to the ethereum contracts | |||
|
|
|||
| #![forbid(unsafe_code)] | |||
| #![warn(missing_docs)] | |||
| // #![warn(missing_docs)] | |||
There was a problem hiding this comment.
Struggling to silence the abigen! warnings ugh
luketchang
commented
Oct 7, 2021
Comment on lines
14
to
17
| abigen!( | ||
| EthereumHomeInternal, | ||
| "./chains/optics-ethereum/abis/Home.abi.json" | ||
| ); |
There was a problem hiding this comment.
Getting these bizarre errors only when running cargo test (why PR is failing CI). cargo build works fine. @prestwich how to fix these weird abigen path errors?
Doc-tests optics-ethereum
error: failed to get ABI JSON
Caused by:
0: failed to read artifact JSON file with path /Users/luketchang/Desktop/optics/optics-monorepo/rust/chains/optics-ethereum/chains/optics-ethereum/abis/Home.abi.json
1: No such file or directory (os error 2)
--> /Users/luketchang/Desktop/optics/optics-monorepo/rust/chains/optics-ethereum/src/home_indexer.rs:16:5
|
16 | "./chains/optics-ethereum/abis/Home.abi.json"
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: failed to get ABI JSON
Caused by:
0: failed to read artifact JSON file with path /Users/luketchang/Desktop/optics/optics-monorepo/rust/chains/optics-ethereum/chains/optics-ethereum/abis/Home.abi.json
1: No such file or directory (os error 2)
--> /Users/luketchang/Desktop/optics/optics-monorepo/rust/chains/optics-ethereum/src/settings.rs:17:5
|
17 | "./chains/optics-ethereum/abis/Home.abi.json"
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error[E0432]: unresolved import `crate::EthereumHomeIndexer`
--> /Users/luketchang/Desktop/optics/optics-monorepo/rust/chains/optics-ethereum/src/settings.rs:12:5
|
12 | use crate::EthereumHomeIndexer;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ no `EthereumHomeIndexer` in the root
error[E0412]: cannot find type `EthereumHomeInternal` in this scope
--> /Users/luketchang/Desktop/optics/optics-monorepo/rust/chains/optics-ethereum/src/home_indexer.rs:25:19
|
25 | contract: Arc<EthereumHomeInternal<M>>,
| ^^^^^^^^^^^^^^^^^^^^ not found in this scope
|
help: consider importing one of these items
|
1 | use optics_ethereum::EthereumHomeInternal;
|
1 | use optics_ethereum::settings::EthereumHomeInternal;
|
error: aborting due to 4 previous errors
There was a problem hiding this comment.
i believe we are falling prey to rust-lang/cargo#9427 here
…g dependencies on old Ethereum home indexer
luketchang
force-pushed
the
luke/db-home-refactor
branch
from
908c598 to
4e008ce
Compare
added 3 commits
October 13, 2021 17:11
|
Closing in favor of #902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates home-indexing and db-syncing logic from the concept of a
homecontract (home interface).HomeIndexertrait inoptics-core, who's sole responsibility is to retrieve updates and messages from home contract eventsSyncingHomeDBinoptics-base, which contains aHomeIndexerand aHomeDBand keeps the agent'sHomeDBup to date by indexing home contract events and updating the dbSyncingHomeDBand will start the indexing task onrunHomeDBinstead of accessing theirHomeDBthrough thehomeobjectCloses #870