Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide script to verify git branch matches proposed contracts system #5083

Closed
m-chrzan opened this issue Sep 14, 2020 · 0 comments · Fixed by #5111
Closed

Provide script to verify git branch matches proposed contracts system #5083

m-chrzan opened this issue Sep 14, 2020 · 0 comments · Fixed by #5111
Assignees

Comments

@m-chrzan
Copy link
Contributor

m-chrzan commented Sep 14, 2020

Expected Behavior

yarn verify-proposal -b BRANCH -n NETWORK -p PROPOSAL verifies that the Solidity source codes under packages/protocol/contracts.on branch BRANCH match the bytecodes deployed to NETWORK, including any changes that PROPOSAL would cause.

Current Behavior

No such script.

@m-chrzan m-chrzan self-assigned this Sep 14, 2020
@mergify mergify bot closed this as completed in #5111 Oct 8, 2020
mergify bot pushed a commit that referenced this issue Oct 8, 2020
### Description

Adds two bash wrappers around `verify-bytecodes`:

* `verify-deployed` checks that the current Celo contracts correspond to Solidity sources on a given branch.
* `verify-release` checks that after executing a given proposal, the onchain contracts will correspond to Solidity sources on a given branch.

### Other changes

Added a `-f` flag to several of our bash scripts, and modified `truffle-config` to take a `--forno` parameter that allows Truffle scripts to run with a Forno provider on testnets/the mainnet for which a Forno instance exists.

Added comments, cleaned up scripts.

### Tested

#### verify-deployed
    celotooljs port-forward -e baklava
    yarn verify-deployed -n baklava -b baklava -f

#### verify-release

    git checkout rc1
    yarn devchain generate-tar devchain.tar.gz
    git checkout -
    yarn devchain run-tar devchain.tar.gz
    yarn make-release -a rc1 -b m-chrzan/bytecode-scripts -n development -p proposal.json -i example-initialize-data.json -r report.json
    yarn verify-release -b m-chrzan/bytecode-scripts -n development -p proposal.json

### Related issues

- Fixes #5082
- Fixes #5083

### Backwards compatibility

+1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant