Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide script to verify git branch matches deployed contracts system #5082

Closed
m-chrzan opened this issue Sep 14, 2020 · 0 comments · Fixed by #5111
Closed

Provide script to verify git branch matches deployed contracts system #5082

m-chrzan opened this issue Sep 14, 2020 · 0 comments · Fixed by #5111
Assignees
@yorhodes @m-chrzan
Labels
protocol All issues relating to protocol packages protocol-tools

Comments

@m-chrzan
Copy link
Contributor

m-chrzan commented Sep 14, 2020 •
edited
Loading

Expected Behavior

yarn verify-bytecodes -b BRANCH -n NETWORK verifies that the Solidity source codes under packages/protocol/contracts.on branch BRANCH match the bytecodes deployed to NETWORK.

Current Behavior

No such script
@m-chrzan m-chrzan added protocol All issues relating to protocol packages protocol-tools labels Sep 14, 2020
@m-chrzan m-chrzan self-assigned this Sep 14, 2020
@nambrot nambrot mentioned this issue Sep 15, 2020
Closed
60 tasks
@m-chrzan m-chrzan mentioned this issue Sep 17, 2020
Merged
@yorhodes yorhodes self-assigned this Sep 24, 2020
@mergify mergify bot closed this as completed in #5111 Oct 8, 2020
mergify bot pushed a commit that referenced this issue Oct 8, 2020
@m-chrzan
Scripts for verifying bytecodes (#5111)
41d3d03 
### Description

Adds two bash wrappers around `verify-bytecodes`:

* `verify-deployed` checks that the current Celo contracts correspond to Solidity sources on a given branch.
* `verify-release` checks that after executing a given proposal, the onchain contracts will correspond to Solidity sources on a given branch.

### Other changes

Added a `-f` flag to several of our bash scripts, and modified `truffle-config` to take a `--forno` parameter that allows Truffle scripts to run with a Forno provider on testnets/the mainnet for which a Forno instance exists.

Added comments, cleaned up scripts.

### Tested

#### verify-deployed
    celotooljs port-forward -e baklava
    yarn verify-deployed -n baklava -b baklava -f

#### verify-release

    git checkout rc1
    yarn devchain generate-tar devchain.tar.gz
    git checkout -
    yarn devchain run-tar devchain.tar.gz
    yarn make-release -a rc1 -b m-chrzan/bytecode-scripts -n development -p proposal.json -i example-initialize-data.json -r report.json
    yarn verify-release -b m-chrzan/bytecode-scripts -n development -p proposal.json

### Related issues

- Fixes #5082
- Fixes #5083

### Backwards compatibility

+1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yorhodes yorhodes

@m-chrzan m-chrzan

Labels
protocol All issues relating to protocol packages protocol-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scripts for verifying bytecodes celo-org/celo-monorepo
2 participants
@yorhodes @m-chrzan