analyzer: add options to cover all cases #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integer-format error-format bool-format hex-format string-format
Closed
|
I did not have a good command to generate all the test files... |
ccoVeille
reviewed
Jan 31, 2025
Comment on lines
+65
to
75
| r.Flags.BoolVar(&n.intFormat.enabled, "integer-format", true, "enable/disable optimization of integer formatting") | ||
| r.Flags.BoolVar(&n.intFormat.intConv, "int-conversion", true, "optimizes even if it requires an int or uint type cast") | ||
| r.Flags.BoolVar(&n.errFormat.enabled, "error-format", true, "enable/disable optimization of error formatting") | ||
| r.Flags.BoolVar(&n.errFormat.errError, "err-error", false, "optimizes into err.Error() even if it is only equivalent for non-nil errors") | ||
| r.Flags.BoolVar(&n.errFormat.errorf, "errorf", true, "optimizes fmt.Errorf") | ||
| r.Flags.BoolVar(&n.boolFormat, "bool-format", true, "enable/disable optimization of bool formatting") | ||
| r.Flags.BoolVar(&n.hexFormat, "hex-format", true, "enable/disable optimization of hex formatting") | ||
| r.Flags.BoolVar(&n.strFormat.enabled, "string-format", true, "enable/disable optimization of string formatting") | ||
| r.Flags.BoolVar(&n.strFormat.sprintf1, "sprintf1", true, "optimizes fmt.Sprintf with only one argument") | ||
| r.Flags.BoolVar(&n.strFormat.strconcat, "strconcat", true, "optimizes into strings concatenation") | ||
| r.Flags.BoolVar(&n.fiximports, "fiximports", true, "fix needed imports from other fixes") |
There was a problem hiding this comment.
Suggested change
| r.Flags.BoolVar(&n.intFormat.enabled, "integer-format", true, "enable/disable optimization of integer formatting") | |
| r.Flags.BoolVar(&n.intFormat.intConv, "int-conversion", true, "optimizes even if it requires an int or uint type cast") | |
| r.Flags.BoolVar(&n.errFormat.enabled, "error-format", true, "enable/disable optimization of error formatting") | |
| r.Flags.BoolVar(&n.errFormat.errError, "err-error", false, "optimizes into err.Error() even if it is only equivalent for non-nil errors") | |
| r.Flags.BoolVar(&n.errFormat.errorf, "errorf", true, "optimizes fmt.Errorf") | |
| r.Flags.BoolVar(&n.boolFormat, "bool-format", true, "enable/disable optimization of bool formatting") | |
| r.Flags.BoolVar(&n.hexFormat, "hex-format", true, "enable/disable optimization of hex formatting") | |
| r.Flags.BoolVar(&n.strFormat.enabled, "string-format", true, "enable/disable optimization of string formatting") | |
| r.Flags.BoolVar(&n.strFormat.sprintf1, "sprintf1", true, "optimizes fmt.Sprintf with only one argument") | |
| r.Flags.BoolVar(&n.strFormat.strconcat, "strconcat", true, "optimizes into strings concatenation") | |
| r.Flags.BoolVar(&n.fiximports, "fiximports", true, "fix needed imports from other fixes") | |
| r.Flags.BoolVar(&n.intFormat.activated, "integer-format", true, "activate/deactivate optimization of integer formatting") | |
| r.Flags.BoolVar(&n.intFormat.intConv, "int-conversion", true, "optimizes even if it requires an int or uint type cast") | |
| r.Flags.BoolVar(&n.errFormat.activated, "error-format", true, "activate/deactivate optimization of error formatting") | |
| r.Flags.BoolVar(&n.errFormat.errError, "err-error", false, "optimizes into err.Error() even if it is only equivalent for non-nil errors") | |
| r.Flags.BoolVar(&n.errFormat.errorf, "errorf", true, "optimizes fmt.Errorf") | |
| r.Flags.BoolVar(&n.boolFormat, "bool-format", true, "activate/deactivate optimization of bool formatting") | |
| r.Flags.BoolVar(&n.hexFormat, "hex-format", true, "activate/deactivate optimization of hex formatting") | |
| r.Flags.BoolVar(&n.strFormat.activated, "string-format", true, "activate/deactivate optimization of string formatting") | |
| r.Flags.BoolVar(&n.strFormat.sprintf1, "sprintf1", true, "optimizes fmt.Sprintf with only one argument") | |
| r.Flags.BoolVar(&n.strFormat.strconcat, "strconcat", true, "optimizes into strings concatenation") | |
| r.Flags.BoolVar(&n.fiximports, "fiximports", true, "fix needed imports from other fixes") |
ccoVeille
reviewed
Feb 1, 2025
This was referenced Feb 5, 2025
Closed
This was referenced Feb 6, 2025
|
The code was working as a CLI. Unfortunately the code used for the testing was incomplete and misleading. Deactivating a flag such as Same for So the tests and golden files that were added were wrong, this is blocking as it prevent the code to be refactored further The problem is sorted with #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #39, new version of #41
@alexandear @mmorel-35 @ccoVeille
What do you think of this ?