Add checker name to analysis.Diagnostic

[ccoVeille]

Following work started with #31

• chore: refactor Diagnostic declaration #31

And settings added via #42

• analyzer: add options to cover all cases #42

All reported errors could now be identified by a unique name

We can use the checker argument in newAnalysisDiagnostic

perfsprint/analyzer/diagnostic.go

Line 7 in eff1a84

func newAnalysisDiagnostic(

[ccoVeille]

Implementation question about checker names, the ones reported by the diagnosis

Are they limited to

• integer-format
• error-format
• string-format
• bool-format
• hex-format

0r are there reported with the sub checker linked to its option ?

• integer-format
• integer-format.int-conversion
• error-format
• error-format.errorf
• error-format.err-error
• string-format
• string-format.sprintf1
• string-format.strconcat
• bool-format
• hex-format

[catenacyber]

Are they limited to

integer-format
error-format
string-format
bool-format
hex-format

Yes :-)

[ccoVeille]

@mmorel-35 you were the one who brought the idea of adding the checker name. Wanna do it?

[mmorel-35]

Thank you for the offer @ccoVeille , I don't have the bandwidth right now so if anyone wants to take care of it soon they are totally free to do so.
Concerning the checkers naming, I agree with @catenacyber proposition.

[ccoVeille]

I accept the challenge. If you guys don't get news from me. Feel free to take it back.

[ccoVeille]

Currently blocked by

• fix: refactor unit tests so they don't depend on previous tests #44
• chore: link flags and their default values #45

[catenacyber]

No longer blocked