feat: improve diagnostic #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An absolute URL is now provided in the diagnostic message. The Category field helps to classify the diagnostic message in the documentation. https://pkg.go.dev/golang.org/x/tools/go/analysis#Diagnostic The Readme file is not yet updated to add these html anchors.
ccoVeille
commented
Feb 8, 2025
| @@ -58,6 +58,7 @@ func New() *analysis.Analyzer { | |||
| n := newPerfSprint() | |||
| r := &analysis.Analyzer{ | |||
| Name: "perfsprint", | |||
| URL: "https://github.com/catenacyber/perfsprint", | |||
| Doc: "Checks that fmt.Sprintf can be replaced with a faster alternative.", | |||
There was a problem hiding this comment.
BTW @alexandear @mmorel-35 @catenacyber Do you have a better text to suggest for this field ?
Here is mine
Suggested change
| Doc: "Checks that fmt.Sprintf can be replaced with a faster alternative.", | |
| Doc: "Checks instances of fmt.Sprintf, fmt.Sprint, and fmt.Errorf that could be replaced with more performant alternatives.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An absolute URL is now provided in the diagnostic message.
The Category field helps to classify the diagnostic message in the documentation.
https://pkg.go.dev/golang.org/x/tools/go/analysis#Diagnostic
The Readme file is not yet updated to add these html anchors.