Fixed typo in "benchmark name" column width calculation. #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horenmar
force-pushed
the
benchmark_width_fix
branch
from
850fbad to
104642b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
=======================================
Coverage 86.49% 86.49%
=======================================
Files 131 131
Lines 3900 3900
=======================================
Hits 3373 3373
Misses 527 527 |
|
Thanks, the changes, and the analysis seems reasonable. The failing CI was because of a test that expected the specific look of the header, including whitespace. I updated it so that the new, shortened, header is checked instead. |
horenmar
force-pushed
the
benchmark_width_fix
branch
from
104642b to
6d701b2
Compare
horenmar
added a commit
that referenced
this pull request
Apr 21, 2020
--- Improvements --- * Running tests in random order (`--order rand`) has been reworked significantly (#1908) * Given same seed, all platforms now produce the same order * Given same seed, the relative order of tests does not change if you select only a subset of them * Vector matchers support custom allocators (#1909) * `|` and `&` (bitwise or and bitwise and) are now supported in `CHECK` and `REQUIRE` * The resulting type must be convertible to `bool` --- Fixes --- * Fixed computation of benchmarking column widths in ConsoleReporter (#1885, #1886) * Suppressed clang-tidy's `cppcoreguidelines-pro-type-vararg` in assertions (#1901) * It was a false positive trigered by the new warning support workaround * Fixed bug in test specification parser handling of OR'd patterns using escaping (#1905) --- Miscellaneous --- * Worked around IBM XL's codegen bug (#1907) * It would emit code for _destructors_ of temporaries in an unevaluated context * Improved detection of stdlib's support for `std::uncaught_exceptions` (#1911)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The width for the "benchmark name" column in full analysis mode is too large, which makes the output spill beyond
CATCH_CONFIG_CONSOLE_WIDTH.The width was set to
CATCH_CONFIG_CONSOLE_WIDTH - 32, but the other three columns are each 14 wide, for a total of 42, not 32, thus giving a total line length ofCATCH_CONFIG_CONSOLE_WIDTH + 10, when it should obviously not exceedCATCH_CONFIG_CONSOLE_WIDTH. (My guess is that32was a typo for42.)The best solution I see is setting the width of the "benchmark name" column to
CATCH_CONFIG_CONSOLE_WIDTH - 43, the same as it is in the no analysis case. This PR does that.GitHub Issues
Fixes #1885.