-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"benchmark name" has overly wide column width #1885
Labels
Comments
uckelman-sf
added a commit
to uckelman-sf/Catch2
that referenced
this issue
Mar 19, 2020
This comment was marked as spam.
This comment was marked as spam.
horenmar
pushed a commit
to uckelman-sf/Catch2
that referenced
this issue
Mar 25, 2020
horenmar
pushed a commit
to uckelman-sf/Catch2
that referenced
this issue
Mar 25, 2020
horenmar
pushed a commit
that referenced
this issue
Mar 26, 2020
horenmar
added a commit
that referenced
this issue
Apr 21, 2020
--- Improvements --- * Running tests in random order (`--order rand`) has been reworked significantly (#1908) * Given same seed, all platforms now produce the same order * Given same seed, the relative order of tests does not change if you select only a subset of them * Vector matchers support custom allocators (#1909) * `|` and `&` (bitwise or and bitwise and) are now supported in `CHECK` and `REQUIRE` * The resulting type must be convertible to `bool` --- Fixes --- * Fixed computation of benchmarking column widths in ConsoleReporter (#1885, #1886) * Suppressed clang-tidy's `cppcoreguidelines-pro-type-vararg` in assertions (#1901) * It was a false positive trigered by the new warning support workaround * Fixed bug in test specification parser handling of OR'd patterns using escaping (#1905) --- Miscellaneous --- * Worked around IBM XL's codegen bug (#1907) * It would emit code for _destructors_ of temporaries in an unevaluated context * Improved detection of stdlib's support for `std::uncaught_exceptions` (#1911)
horenmar
pushed a commit
that referenced
this issue
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The "benchmark name" column is too wide for the default
CATCH_CONFIG_CONSOLE_WIDTH
in full analysis mode, which prevents output from appearing as intended on a single line in a terminal which is 80 columns wide.Example of current output:
Expected behavior
Reproduction steps
Use
BENCHMARK
in a test. See the output.Additional context
The problem is caused by setting the "benchmark name" column width to
CATCH_CONFIG_CONSOLE_WIDTH - 32
inConsoleReporter::ConsoleReporter()
, when the other three columns are each 14 characters wide. (14*3 = 42 > 32).The text was updated successfully, but these errors were encountered: