Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: _key_value for schedulers in case of multiple optimizers fixed #1146

Merged
merged 1 commit into from
Mar 28, 2021
Merged

fix: _key_value for schedulers in case of multiple optimizers fixed #1146

merged 1 commit into from
Mar 28, 2021

Conversation

bagxi
Copy link
Member

@bagxi bagxi commented Mar 28, 2021 •
edited
Loading

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

PS

  • I know, that I could join slack for pull request discussion.

@bagxi bagxi requested review from ditwoo and Scitator as code owners March 28, 2021 13:50
@bagxi bagxi added the bug Something isn't working label Mar 28, 2021
@bagxi bagxi self-assigned this Mar 28, 2021
github-actions[bot]
github-actions bot reviewed Mar 28, 2021
View reviewed changes
catalyst/runners/config.py Outdated Show resolved Hide resolved
catalyst/runners/hydra.py Outdated Show resolved Hide resolved
@bagxi bagxi force-pushed the fix/scheduler_kw branch from 01772a7 to 1865696 Compare March 28, 2021 14:31
@bagxi bagxi force-pushed the fix/scheduler_kw branch from 1865696 to 7926daf Compare March 28, 2021 15:00
@Scitator Scitator merged commit df570a4 into master Mar 28, 2021
@mergify mergify bot deleted the fix/scheduler_kw branch March 28, 2021 15:26
zkid18 pushed a commit to zkid18/catalyst that referenced this pull request Apr 4, 2021
@bagxi @zkid18
fix: _key_value for schedulers in case of multiple optimizers fixed (…
a5334fe 
…catalyst-team#1146)
Scitator added a commit that referenced this pull request Apr 9, 2021
@zkid18 @denyhoof
@Atharva-Phatak @Scitator @bagxi @elephantmipt @ditwoo @ssktotoro
Fix hitrate (#1159)
9e381c8 
* add movielens

* First hitrate metric version

* metrge with upstream

* fix topk_map

* fix error in map

* tests for map

* top_k ndcg

* edit changelog

* edit the tabs

* check codestyle

* check the intent

* check the intent

* remove trailing whitespace

* fixed hitrate

* fixed the docs

* hitrate

* Additive margin softmax (#1131)

* Added Additive-margin softmax

* update changelog.md

* Readme update2 (#1142)

* readme

* batch overfit fix for reproducibility

* batch overfit fix for reproducibility

* readme

* readme update

* extra Config/Hydra API fixes

* codestyle

* updated dl_cpu(workflows)- For passing CI-Tests (#1135)

* updated dl_cpu

* Updated-requirements-ml.txt

* corrected the mistake

* Update dl_cpu.yml

* Update requirements-ml.txt

* Kept dl_cpu 20.04-3.6 minimal as requested

* Corrected the mistakes

* Add requirements parameter

* Update dl_cpu.yml

* Update dl_cpu.yml

Co-authored-by: Sergey Kolesnikov <[email protected]>

* fix: `_key_value` for schedulers in case of multiple optimizers fixed (#1146)

* Github CI fixes (#1143)

* verbose

* Utils callbacks (#1127)

* quantization.py

* onnx and quantization

* tracing.py

* docs

* fix

* fix

* quantization test

* fix test

* fix comments

* fix comments

* Update catalyst/callbacks/__init__.py

Co-authored-by: Sergey Kolesnikov <[email protected]>

* tests

* tests

* tests

* tests

* tests

* pycharm tricks

* extra tests

* Utils callbacks (#1145)

* quantization.py

* onnx and quantization

* tracing.py

* docs

* fix

* fix

* quantization test

* fix test

* fix comments

* fix comments

* quantization example

* examples

* CHANGELOG.md

* fix

* fix

* Apply suggestions from code review

Co-authored-by: Sergey Kolesnikov <[email protected]>

* extra tests 2

* extra tests 2

* extra tests 2

* extra tests 2

* extra tests 2

* extra tests 2

* extra tests 2

* extra tests 2

Co-authored-by: Nikita Balagansky <[email protected]>

* Engine docs (#1141)

* typings & few docs

* typing fix; disabled `dist.barrier()` in optimizer step for ddp

* docs

* docs: fixed long lines with docs

* docs fixes

* optimizer args

* removed empty line

Co-authored-by: Dmytro Doroshenko <[email protected]>

* v21.03.1

* v21.03: minimal version fix (#1147)

* minimal version fix

* docs

* fix: nested dicts in loaders_params/samplers_params overriding (#1150)

* docs (#1152)

* Github CI fix (#1148)

* fix

* fix

* Niftireader (#1151)

* changes for NiftiReader

* adding import statement that was needed and fixing codestyle

* updated CHANGELOG

* removing unnecesary documentation

* fixing codestyle

* updated docs and requirements

* adding a space

* not importing nibabel for docs

* fixing typo

* adding step for contrib pip caching

* fixed codestyle and added a test for reader that uncovered a mistake :)

* hopefully fixing imports

* adding sergey suggested fix

* fixing deploy_push.yml

* updating workflows

Co-authored-by: Kevin Wang <[email protected]>
Co-authored-by: Kevin Wang <[email protected]>

* add changelog

* solved runtime error

* hitrate calculation

Co-authored-by: Daniel Chepenko <[email protected]>
Co-authored-by: denyhoof <[email protected]>
Co-authored-by: Даниил <[email protected]>
Co-authored-by: Atharva Phatak <[email protected]>
Co-authored-by: Sergey Kolesnikov <[email protected]>
Co-authored-by: Yauheni Kachan <[email protected]>
Co-authored-by: Nikita Balagansky <[email protected]>
Co-authored-by: Dmytro Doroshenko <[email protected]>
Co-authored-by: Kevin Wang <[email protected]>
Co-authored-by: Kevin Wang <[email protected]>
Co-authored-by: Kevin Wang <[email protected]>
zkid18 pushed a commit to zkid18/catalyst that referenced this pull request Jul 4, 2021
@bagxi @zkid18
fix: _key_value for schedulers in case of multiple optimizers fixed (…
5b68838 
…catalyst-team#1146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ditwoo ditwoo Awaiting requested review from ditwoo

@Scitator Scitator Awaiting requested review from Scitator Scitator is a code owner

Assignees

@bagxi bagxi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagxi @Scitator