Utils callbacks #1145

elephantmipt · 2021-03-28T11:29:50Z

Before submitting (checklist)

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contribution guide?
Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
Did you make sure to update the docs? We use Google format for all the methods and classes.
Did you check the docs with make check-docs?
Did you write any new necessary tests?
Did you check that your code passes the unit tests pytest . ?
Did you add your new functionality to the docs?
Did you update the CHANGELOG?

Description

Related Issue

Type of Change

Examples / docs / tutorials / contributors update
Bug fix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves an existing feature)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

PS

I know, that I could join slack for pull request discussion.

…backs

pep8speaks · 2021-03-28T11:29:54Z

Hello @elephantmipt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file catalyst/callbacks/quantization.py:

Line 93:100: E501 line too long (102 > 99 characters)

Comment last updated at 2021-03-28 12:19:01 UTC

mergify · 2021-03-28T11:31:22Z

This pull request is now in conflicts. @elephantmipt, could you fix it? 🙏

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

catalyst/callbacks/quantization.py|106 col 100| W505 doc line too long (100 > 99 characters)
catalyst/callbacks/quantization.py|131 col 1| D102 Missing docstring in public method

github-actions · 2021-03-28T11:35:40Z

catalyst/utils/quantization.py

@@ -12,7 +12,8 @@ def quantize_model(
    """Function to quantize model weights.

    Args:
-        model (Model): model to quantize
+        logdir: path to folder for saving


[pep8] _{reported by reviewdog 🐶}
DAR102 Excess parameter(s) in Docstring: + filename

catalyst/callbacks/tracing.py

catalyst/callbacks/quantization.py

mergify · 2021-03-28T11:41:14Z

This pull request is now in conflicts. @elephantmipt, could you fix it? 🙏

…backs

catalyst/utils/quantization.py

catalyst/callbacks/tracing.py

github-actions · 2021-03-28T11:51:33Z

catalyst/callbacks/quantization.py

+        else:
+            self.filename = filename
+
+    def on_stage_end(self, runner: "IRunner") -> None:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

catalyst/callbacks/__init__.py

catalyst/callbacks/onnx.py

catalyst/callbacks/tracing.py

* verbose * Utils callbacks (#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <[email protected]> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <[email protected]> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <[email protected]>

* verbose * Utils callbacks (catalyst-team#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <[email protected]> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (catalyst-team#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <[email protected]> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <[email protected]>

* add movielens * First hitrate metric version * metrge with upstream * fix topk_map * fix error in map * tests for map * top_k ndcg * edit changelog * edit the tabs * check codestyle * check the intent * check the intent * remove trailing whitespace * fixed hitrate * fixed the docs * hitrate * Additive margin softmax (#1131) * Added Additive-margin softmax * update changelog.md * Readme update2 (#1142) * readme * batch overfit fix for reproducibility * batch overfit fix for reproducibility * readme * readme update * extra Config/Hydra API fixes * codestyle * updated dl_cpu(workflows)- For passing CI-Tests (#1135) * updated dl_cpu * Updated-requirements-ml.txt * corrected the mistake * Update dl_cpu.yml * Update requirements-ml.txt * Kept dl_cpu 20.04-3.6 minimal as requested * Corrected the mistakes * Add requirements parameter * Update dl_cpu.yml * Update dl_cpu.yml Co-authored-by: Sergey Kolesnikov <[email protected]> * fix: `_key_value` for schedulers in case of multiple optimizers fixed (#1146) * Github CI fixes (#1143) * verbose * Utils callbacks (#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <[email protected]> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <[email protected]> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <[email protected]> * Engine docs (#1141) * typings & few docs * typing fix; disabled `dist.barrier()` in optimizer step for ddp * docs * docs: fixed long lines with docs * docs fixes * optimizer args * removed empty line Co-authored-by: Dmytro Doroshenko <[email protected]> * v21.03.1 * v21.03: minimal version fix (#1147) * minimal version fix * docs * fix: nested dicts in loaders_params/samplers_params overriding (#1150) * docs (#1152) * Github CI fix (#1148) * fix * fix * Niftireader (#1151) * changes for NiftiReader * adding import statement that was needed and fixing codestyle * updated CHANGELOG * removing unnecesary documentation * fixing codestyle * updated docs and requirements * adding a space * not importing nibabel for docs * fixing typo * adding step for contrib pip caching * fixed codestyle and added a test for reader that uncovered a mistake :) * hopefully fixing imports * adding sergey suggested fix * fixing deploy_push.yml * updating workflows Co-authored-by: Kevin Wang <[email protected]> Co-authored-by: Kevin Wang <[email protected]> * add changelog * solved runtime error * hitrate calculation Co-authored-by: Daniel Chepenko <[email protected]> Co-authored-by: denyhoof <[email protected]> Co-authored-by: Даниил <[email protected]> Co-authored-by: Atharva Phatak <[email protected]> Co-authored-by: Sergey Kolesnikov <[email protected]> Co-authored-by: Yauheni Kachan <[email protected]> Co-authored-by: Nikita Balagansky <[email protected]> Co-authored-by: Dmytro Doroshenko <[email protected]> Co-authored-by: Kevin Wang <[email protected]> Co-authored-by: Kevin Wang <[email protected]> Co-authored-by: Kevin Wang <[email protected]>

* verbose * Utils callbacks (catalyst-team#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <[email protected]> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (catalyst-team#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <[email protected]> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <[email protected]>

elephantmipt and others added 18 commits March 21, 2021 15:53

quantization.py

8b9a877

Merge branch 'master' into utils_callbacks

5da6014

onnx and quantization

346092b

Merge remote-tracking branch 'origin/utils_callbacks' into utils_call…

223f02f

…backs

tracing.py

0960d02

docs

677362d

fix

68637cb

fix

49ed408

Merge branch 'master' into utils_callbacks

31f0e5f

quantization test

b00287b

Merge remote-tracking branch 'origin/utils_callbacks' into utils_call…

e1228e1

…backs

Merge branch 'master' into utils_callbacks

fe88234

fix test

8642b58

Merge remote-tracking branch 'origin/utils_callbacks' into utils_call…

c9cb37c

…backs

fix comments

18b2396

fix comments

6619698

quantization example

ae69d2c

examples

12b6d9e

elephantmipt requested review from bagxi, ditwoo and Scitator as code owners March 28, 2021 11:29

CHANGELOG.md

96fe0ad

fix

b92d27f

github-actions bot reviewed Mar 28, 2021

View reviewed changes

Merge branch 'master' into utils_callbacks

6ff1d20

Scitator changed the base branch from master to github-ci-fix March 28, 2021 11:41

fix

e066134

Merge remote-tracking branch 'origin/utils_callbacks' into utils_call…

634e05e

…backs

github-actions bot reviewed Mar 28, 2021

View reviewed changes

Merge branch 'github-ci-fix' into utils_callbacks

18814e7

Scitator reviewed Mar 28, 2021

View reviewed changes

catalyst/callbacks/__init__.py Outdated Show resolved Hide resolved

catalyst/callbacks/onnx.py Outdated Show resolved Hide resolved

catalyst/callbacks/tracing.py Outdated Show resolved Hide resolved

Apply suggestions from code review

4901448

Scitator approved these changes Mar 28, 2021

View reviewed changes

Scitator merged commit 5983667 into github-ci-fix Mar 28, 2021

mergify bot deleted the utils_callbacks branch March 28, 2021 12:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Utils callbacks #1145

Utils callbacks #1145

elephantmipt commented Mar 28, 2021

pep8speaks commented Mar 28, 2021 •

edited

Loading

mergify bot commented Mar 28, 2021

github-actions bot left a comment

github-actions bot Mar 28, 2021

mergify bot commented Mar 28, 2021

github-actions bot Mar 28, 2021

Utils callbacks #1145

Utils callbacks #1145

Conversation

elephantmipt commented Mar 28, 2021

Before submitting (checklist)

Description

Related Issue

Type of Change

PR review

pep8speaks commented Mar 28, 2021 • edited Loading

Comment last updated at 2021-03-28 12:19:01 UTC

mergify bot commented Mar 28, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Mar 28, 2021

Choose a reason for hiding this comment

mergify bot commented Mar 28, 2021

github-actions bot Mar 28, 2021

Choose a reason for hiding this comment

pep8speaks commented Mar 28, 2021 •

edited

Loading