Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding Koa plugin #1

Merged
merged 48 commits into from
Jul 17, 2020
Merged

feat: adding Koa plugin #1

merged 48 commits into from
Jul 17, 2020

Conversation

carolinee21
Copy link
Owner

@carolinee21 carolinee21 commented Jul 14, 2020 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • This instrumentation adds traces to middleware for both the Koa core and Koa Router modules.

  • Some example traces are shown here: Example Koa Instrumentation in Zipkin

  • User friendly example code is also added under examples/koa

carolinee21 added 30 commits June 24, 2020 14:40
@carolinee21
chore: add tsconfig
e80ceda
@carolinee21
chore: add tslint
efca91b
@carolinee21
chore: add standard license
199cb7d
@carolinee21
chore: add npmignore
55f9a86
@carolinee21
chore: initial package config
1c684fc
@carolinee21
docs: initial README
5241daa
@carolinee21
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
6763375 
…try-js-contrib
@carolinee21
chore: create initial structure
a084a1d
@carolinee21
chore: adds traces to Application.use method itself (on instantiation)
4fb5597
@carolinee21
feat: traces for app.use
a66102c
@carolinee21
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
a16d6a8 
…try-js-contrib
@carolinee21
chore: update typescript version
3b1e1e5
@carolinee21
chore: return original layer result
9910682
@carolinee21
chore: remove app.use span based on design
aec43b1
@carolinee21
chore: refactor span attribute assignments into util
c681bd0
@carolinee21
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
dfea6b6 
…try-js-contrib
@carolinee21
chore: add router types
69a4e04
@carolinee21
feat: added tracing for koa-router functions and routes
3101050
@carolinee21
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
aa4fc44 
…try-js-contrib into master
@carolinee21
feat: don't create koa spans without root span
1b35f8b
@carolinee21
feat: added base tests for Koa core and Koa router
d8f72f4
@carolinee21
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
1315670 
…try-js-contrib into master
@carolinee21
chore: finalizing plugin
0200d23
@carolinee21
feat: added kLayerPatched check
9b93428
@carolinee21
test: creating example code for Koa plugin
19ad821
@carolinee21
chore: cleaning up code
fe75b18
@carolinee21
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
ae5d0e8 
…try-js-contrib into master
@carolinee21
chore: update README
ece953f
@carolinee21
chore: update README
c734e70
@carolinee21
chore: update README
206dd8f
dane1122
dane1122 reviewed Jul 15, 2020
View reviewed changes
examples/koa/client.js Show resolved Hide resolved
examples/koa/client.js Show resolved Hide resolved
examples/koa/server.js Outdated Show resolved Hide resolved
examples/koa/server.js Outdated Show resolved Hide resolved
examples/koa/server.js Show resolved Hide resolved
plugins/node/opentelemetry-plugin-koa/test/koa-router.test.ts Outdated Show resolved Hide resolved
plugins/node/opentelemetry-plugin-koa/test/koa-router.test.ts Outdated Show resolved Hide resolved
plugins/node/opentelemetry-plugin-koa/test/koa.test.ts Outdated Show resolved Hide resolved
plugins/node/opentelemetry-plugin-koa/test/koa.test.ts Outdated Show resolved Hide resolved
plugins/node/opentelemetry-plugin-koa/test/koa.test.ts Outdated Show resolved Hide resolved
yozora
yozora reviewed Jul 17, 2020
View reviewed changes
Copy link

@yozora yozora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the async update. Looks good to me.

plugins/node/opentelemetry-plugin-koa/src/koa.ts Outdated Show resolved Hide resolved
plugins/node/opentelemetry-koa-instrumentation/test/koa-router.test.ts Outdated Show resolved Hide resolved
@carolinee21 carolinee21 merged commit 86bea49 into master Jul 17, 2020
@hairyhenderson hairyhenderson mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yozora yozora yozora left review comments

@dane1122 dane1122 dane1122 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin for Koa
3 participants
@carolinee21 @yozora @dane1122