Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for Koa #93

Closed
carolinee21 opened this issue Jun 18, 2020 · 8 comments · Fixed by carolinee21/opentelemetry-js-contrib#1 or #144
Closed

Plugin for Koa #93

carolinee21 opened this issue Jun 18, 2020 · 8 comments · Fixed by carolinee21/opentelemetry-js-contrib#1 or #144

Comments

@carolinee21
Copy link
Contributor

Is your plugin request related to a problem? Please describe.
Requesting a plugin for the Koa framework

Is it applicable for Node or Browser or both
Node
Do you expect this plugin to be commonly used
Weekly Downloads:
525k

Additional context
Existing plugin for OpenTracing is shown here

@carolinee21
Copy link
Contributor Author

@dyladan Could you please assign this to me? Thanks

@hairyhenderson
Copy link

@carolinee21 Has there been any progress on this? I was just looking for a koa otel plugin 😉

@carolinee21
Copy link
Contributor Author

@hairyhenderson Yes - I have been working on it on this fork and expect to have a PR out in the next week or so. I would appreciate any feedback you have!

@hairyhenderson
Copy link

Awesome! I'll wait for the PR and will have a look when it's up 🙂

@hairyhenderson
Copy link

@carolinee21 should this issue have been closed? It looks like carolinee21#1 only merged it into your fork's master branch 🤔

@dyladan
Copy link
Member

dyladan commented Jul 17, 2020

Nope :)

@dyladan dyladan reopened this Jul 17, 2020
@carolinee21
Copy link
Contributor Author

My apologies - did not realize that the issue would close based on a fork's PR. The formal PR into this repo is now open at #144

@hairyhenderson
Copy link

awesome, thanks @carolinee21 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants