fix(useFocus): resolve focus trap issue #6835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makafsal
requested review from
AlexanderMelox and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6835 +/- ##
==========================================
+ Coverage 81.17% 81.28% +0.10%
==========================================
Files 398 397 -1
Lines 12956 12946 -10
Branches 4283 4279 -4
==========================================
+ Hits 10517 10523 +6
+ Misses 2439 2423 -16
|
amal-k-joy
requested review from
devadula-nandan
and removed request for
sangeethababu9223
devadula-nandan
approved these changes
Feb 10, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 10, 2025
eedbef6
30 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6766
What did you change?
Conditions simplified
How did you test and verify your work?
yarn avtyarn testStorybook