Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): fix for mobile tab selection not closing the dropdown (#941) #952

Merged
merged 4 commits into from
Jul 5, 2018

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jul 1, 2018

Overview

Fixes #867.
Closes #934.

Added

  • A mechanism to force open/closed state of the dropdown in the mobile mode of tab

Changed

  • Clicking on menu item in the mobile mode of tab closes the menu, instead of toggling, using above mechanism

Testing / Reviewing

Testing should make sure our tabs component is not broken.

Copy link
Contributor

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 👍

@marijohannessen marijohannessen merged commit 9467b53 into carbon-design-system:master Jul 5, 2018
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.1.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asudoh asudoh deleted the fix-mobile-tabs branch July 6, 2018 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs in mobile version auto expanded
4 participants