Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs in mobile version auto expanded #867

Closed
gracelo opened this issue Jun 4, 2018 · 2 comments · Fixed by #952
Closed

Tabs in mobile version auto expanded #867

gracelo opened this issue Jun 4, 2018 · 2 comments · Fixed by #952

Comments

@gracelo
Copy link

gracelo commented Jun 4, 2018 •
edited
Loading

Tabs and Tab component in mobile browser could be auto-expanded

Detailed description

Is this issue related to a specific component?
Tabs component

What did you expect to happen? What happened instead? What would you like to see changed?

  1. I go to:
    http://react.carbondesignsystem.com/?selectedKind=Tabs&selectedStory=Default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

  2. Select Tab 1 by default.

  3. Select Tab 3.

  4. Narrow the browser so it is in mobile version. The tabs become a dropdown list.
    Note the list is auto-expanded.

I expect the list is collapsed at the beginning until I click on it.

What browser are you working in?
FF but same for other browsers.

What version of the Carbon Design System are you using?
"carbon-components": "^8.18.3",
"carbon-components-react": "^5.41.0",

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
console

(I don't seem to see any labels that I can choose)
@jenschlot
Copy link

this one is making the new docs homepage design not look great in Mobile...and hindering the view of content.

image 19

Instead of collapsed by default, it is expanded.

rezak-otmani added a commit to rezak-otmani/carbon-components that referenced this issue Jun 25, 2018
@rezak-otmani
fix(Tabs): fix the auto expanded of Tabs in mobile version , resolves c…
d9465ad 
…arbon-design-system#867
rezak-otmani added a commit to rezak-otmani/carbon-components that referenced this issue Jun 26, 2018
@rezak-otmani
fix(Tabs): fix the auto expanded of Tabs in mobile version , resolves c…
a8f9988 
…arbon-design-system#867
@rezak-otmani rezak-otmani mentioned this issue Jun 26, 2018
Closed
asudoh added a commit to asudoh/carbon-components that referenced this issue Jul 1, 2018
@asudoh
fix(tabs): fix for mobile tab selection not closing the dropdown (car…
e92e4f4 
…bon-design-system#941)

Fixes carbon-design-system#867.
Closes carbon-design-system#934.
asudoh added a commit to asudoh/carbon-components that referenced this issue Jul 1, 2018
@asudoh
fix(tabs): fix for mobile tab selection not closing the dropdown (car…
1163817 
…bon-design-system#941)

Fixes carbon-design-system#867.
Closes carbon-design-system#934.
@asudoh asudoh mentioned this issue Jul 1, 2018
Merged
marijohannessen pushed a commit that referenced this issue Jul 5, 2018
@asudoh @marijohannessen
fix(tabs): fix for mobile tab selection not closing the dropdown (#941)…
9467b53 
… (#952)

Fixes #867.
Closes #934.
@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.1.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 15, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): fix for mobile tab selection not closing the dropdown (#941) asudoh/carbon-components
4 participants
@alisonjoseph @jenschlot @gracelo @carbon-bot