fix(tabs): truncate container tab header text with ellipses #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 13f598c https://deploy-preview-5035--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 13f598c |
|
Deploy preview for carbon-components-react ready! Built with commit 13f598c https://deploy-preview-5035--carbon-components-react.netlify.com |
|
Oooo, nice thinking! Looks great on desktop, but when I'm testing in mobile I'm seeing some minor issues with the chevron sizing
|
|
looks like it's caused by the positioning of the chevron inside the padding
I resolved it by applying the same icon positioning logic as the listbox components
|
emyarod
force-pushed
the
5016-container-tabs-text-truncation
branch
from
645921a to
f1090b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5016
This PR adds ellipses for overflow text in container tab headers and mobile tabs. Instead of making the anchor a flex item we keep the inherited inline-block display value and set the line height based on the anchor height and vertical padding to center the text. An alternative approach would be to wrap the text in the anchor in another element
Changelog
New
Changed
Testing / Reviewing
Ensure that the tab variants appear correct, especially with longer tab labels