Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab] Container tabs needs text truncation. #5016

Closed
aagonzales opened this issue Jan 10, 2020 · 3 comments · Fixed by #5035
Closed

[Tab] Container tabs needs text truncation. #5016

aagonzales opened this issue Jan 10, 2020 · 3 comments · Fixed by #5035
Assignees

Comments

@aagonzales
Copy link
Member

The container tab text needs to elipse 16px from the edge like the default tabs do.

Container tabs:
image

Default tabs:
image

@tw15egan
Copy link
Contributor

I've been messing around with this but since that container tab is a flex item, it doesn't want to truncate. A quick fix would be to just set it back to inline-block, but that would cause the tab label to be aligned to the top.

Screen Shot 2020-01-13 at 1 36 53 PM

@aagonzales
Copy link
Member Author

😐 hmm yeah I don't think we want it to top align the text.

@asudoh
Copy link
Contributor

asudoh commented Jan 14, 2020

Seems that the ellipsis thing slipped from the checklist when the container tab was implemented (sorry). I haven't got time to look into this, but if flex item doesn't work, some other tricks in this space I can think of are display: table-cell or changing line height (to the height of the tab).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants