Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ghost button normal and field padding #3364

Merged
merged 10 commits into from
Jul 17, 2019
Merged

fix: ghost button normal and field padding #3364

merged 10 commits into from
Jul 17, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jul 11, 2019

closes #3358

@vpicone vpicone requested review from emyarod and asudoh July 11, 2019 16:34
@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for the-carbon-components ready!

Built with commit 5eac1c9

https://deploy-preview-3364--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for carbon-components-react ready!

Built with commit 5eac1c9

https://deploy-preview-3364--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for carbon-elements ready!

Built with commit 5eac1c9

https://deploy-preview-3364--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jul 11, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit f4ca4a2

https://deploy-preview-3364--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jul 11, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit f4ca4a2

https://deploy-preview-3364--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jul 11, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit f4ca4a2

https://deploy-preview-3364--carbon-elements.netlify.com

emyarod
emyarod approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, pending design approval

laurenmrice
laurenmrice approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jendowns jendowns mentioned this pull request Jul 15, 2019
Merged
@vpicone vpicone requested a review from joshblack July 16, 2019 03:57
vpicone
vpicone commented Jul 17, 2019
View reviewed changes
packages/components/src/globals/scss/_theme-tokens.scss

/// @type Number
/// @access public
/// @group button
/// Uses the same padding-y as field buttons, but removes extra padding-right
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ordered to match normal button padding definitions

@vpicone vpicone requested a review from joshblack July 17, 2019 16:10
@vpicone vpicone merged commit 07da0e5 into carbon-design-system:master Jul 17, 2019
@vpicone vpicone deleted the ghost-button-padding-fix branch July 17, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@emyarod emyarod emyarod approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@asudoh asudoh Awaiting requested review from asudoh

@shixiedesign shixiedesign Awaiting requested review from shixiedesign

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ghost buttons have incorrect padding
5 participants
@vpicone @joshblack @emyarod @laurenmrice @asudoh